Runner Scale Set Helm Chart Issue/Feature?

[splotnicumassmutual]

Hi Team,

I was looking into using gha-runner-scale-set controller and runners, and found an issue with the helm template. Maybe that was the feature asked, however I want to ask.
See - this line -

actions-runner-controller/charts/gha-runner-scale-set/templates/_helpers.tpl

Line 22 in 9afd930

{{- define "gha-runner-scale-set.fullname" -}}

New template defined, however we do not use the right value for next line:

actions-runner-controller/charts/gha-runner-scale-set/templates/_helpers.tpl

Line 23 in 9afd930

{{- $name := default (include "gha-base-name" .) }}

It should be:
{{- $name := default (include "gha-runner-scale-set.name" .) }}

Same for line -

actions-runner-controller/charts/gha-runner-scale-set/templates/_helpers.tpl

Line 31 in 9afd930

{{- printf "%s-%s" (include "gha-base-name" .) .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }}

It should be:
{{- printf "%s-%s" (include "gha-runner-scale-set.name" .) .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }}

I run into an issue when trying to install same chart in, two releases in same namespace.

Happy to provide details if needed