diff --git a/README.md b/README.md index 47bc342c7..37a239741 100644 --- a/README.md +++ b/README.md @@ -2,58 +2,83 @@ [![Basic validation](https://github.com/actions/labeler/actions/workflows/basic-validation.yml/badge.svg?branch=main)](https://github.com/actions/labeler/actions/workflows/basic-validation.yml) -Automatically label new pull requests based on the paths of files being changed. +Automatically label new pull requests based on the paths of files being changed or the branch name. ## Usage ### Create `.github/labeler.yml` -Create a `.github/labeler.yml` file with a list of labels and [minimatch](https://github.com/isaacs/minimatch) globs to match to apply the label. +Create a `.github/labeler.yml` file with a list of labels and config options to match and apply the label. -The key is the name of the label in your repository that you want to add (eg: "merge conflict", "needs-updating") and the value is the path (glob) of the changed files (eg: `src/**/*`, `tests/*.spec.js`) or a match object. +The key is the name of the label in your repository that you want to add (eg: "merge conflict", "needs-updating") and the value is a match object. #### Match Object -For more control over matching, you can provide a match object instead of a simple path glob. The match object is defined as: +The match object allows control over the matching options, you can specify the label to be applied based on the files that have changed or the name of either the base branch or the head branch. For the changed files options you provide a [path glob](https://github.com/isaacs/minimatch#minimatch), and for the branches you provide a regexp to match against the branch name. +The base match object is defined as: ```yml -- any: ['list', 'of', 'globs'] - all: ['list', 'of', 'globs'] +- changed-files: ['list', 'of', 'globs'] +- base-branch: ['list', 'of', 'regexps'] +- head-branch: ['list', 'of', 'regexps'] ``` -One or both fields can be provided for fine-grained matching. Unlike the top-level list, the list of path globs provided to `any` and `all` must ALL match against a path for the label to be applied. +There are two top level keys of `any` and `all`, which both accept the same config options: +```yml +- any: + - changed-files: ['list', 'of', 'globs'] + - base-branch: ['list', 'of', 'regexps'] + - head-branch: ['list', 'of', 'regexps'] +- all: + - changed-files: ['list', 'of', 'globs'] + - base-branch: ['list', 'of', 'regexps'] + - head-branch: ['list', 'of', 'regexps'] +``` +One or all fields can be provided for fine-grained matching. The fields are defined as follows: -* `any`: match ALL globs against ANY changed path -* `all`: match ALL globs against ALL changed paths +* `all`: all of the provided options must match in order for the label to be applied +* `any`: if any of the provided options match then a label will be applied +* `base-branch`: match regexps against the base branch name +* `changed-files`: match glob patterns against the changed paths +* `head-branch`: match regexps against the head branch name -A simple path glob is the equivalent to `any: ['glob']`. More specifically, the following two configurations are equivalent: +If a base option is provided without a top-level key then it will default to `any`. More specifically, the following two configurations are equivalent: ```yml label1: -- example1/* +- changed-files: example1/* ``` and ```yml label1: -- any: ['example1/*'] +- any: + - changed-files: ['example1/*'] ``` -From a boolean logic perspective, top-level match objects are `OR`-ed together and individual match rules within an object are `AND`-ed. Combined with `!` negation, you can write complex matching rules. +From a boolean logic perspective, top-level match objects, and options within `all` are `AND`-ed together and individual match rules within the `any` object are `OR`-ed. If path globs are combined with `!` negation, you can write complex matching rules. #### Basic Examples ```yml # Add 'label1' to any changes within 'example' folder or any subfolders label1: -- example/**/* +- changed-files: example/**/* # Add 'label2' to any file changes within 'example2' folder -label2: example2/* +label2: +- changed-files: example2/* # Add label3 to any change to .txt files within the entire repository. Quotation marks are required for the leading asterisk label3: -- '**/*.txt' +- changed-files: '**/*.txt' + +# Add 'label4' to any PR where the head branch name starts with 'example4' +label4: +- head-branch: '^example4' +# Add 'label5' to any PR where the base branch name starts with 'example5' +label5: +- base-branch: '^example5' ``` #### Common Examples @@ -61,25 +86,37 @@ label3: ```yml # Add 'repo' label to any root file changes repo: -- '*' +- changed-files: '*' # Add '@domain/core' label to any change within the 'core' package '@domain/core': -- package/core/* -- package/core/**/* +- changed-files: + - package/core/* + - package/core/**/* # Add 'test' label to any change to *.spec.js files within the source dir test: -- src/**/*.spec.js +- changed-files: src/**/*.spec.js # Add 'source' label to any change to src files within the source dir EXCEPT for the docs sub-folder source: -- any: ['src/**/*', '!src/docs/*'] +- changed-files: + - any: ['src/**/*', '!src/docs/*'] # Add 'frontend` label to any change to *.js files as long as the `main.js` hasn't changed frontend: -- any: ['src/**/*.js'] - all: ['!src/main.js'] +- any: + - changed-files: ['src/**/*.js'] +- all: + - changed-files: ['!src/main.js'] + + # Add 'feature' label to any PR where the head branch name starts with `feature` or has a `feature` section in the name +feature: + - head-branch: ['^feature', 'feature'] + + # Add 'release' label to any PR that is opened against the `main` branch +release: + - base-branch: 'main' ``` ### Create Workflow @@ -98,7 +135,7 @@ jobs: pull-requests: write runs-on: ubuntu-latest steps: - - uses: actions/labeler@v4 + - uses: actions/labeler@v5 ``` #### Inputs diff --git a/__mocks__/@actions/github.ts b/__mocks__/@actions/github.ts index ea8319f63..b3629370b 100644 --- a/__mocks__/@actions/github.ts +++ b/__mocks__/@actions/github.ts @@ -1,7 +1,13 @@ export const context = { payload: { pull_request: { - number: 123 + number: 123, + head: { + ref: 'head-branch-name' + }, + base: { + ref: 'base-branch-name' + } } }, repo: { diff --git a/__tests__/branch.test.ts b/__tests__/branch.test.ts new file mode 100644 index 000000000..4bd203053 --- /dev/null +++ b/__tests__/branch.test.ts @@ -0,0 +1,210 @@ +import { + getBranchName, + checkAnyBranch, + checkAllBranch, + toBranchMatchConfig, + BranchMatchConfig +} from '../src/branch'; +import * as github from '@actions/github'; + +jest.mock('@actions/core'); +jest.mock('@actions/github'); + +describe('getBranchName', () => { + describe('when the pull requests base branch is requested', () => { + it('returns the base branch name', () => { + const result = getBranchName('base'); + expect(result).toEqual('base-branch-name'); + }); + }); + + describe('when the pull requests head branch is requested', () => { + it('returns the head branch name', () => { + const result = getBranchName('head'); + expect(result).toEqual('head-branch-name'); + }); + }); +}); + +describe('checkAllBranch', () => { + beforeEach(() => { + github.context.payload.pull_request!.head = { + ref: 'test/feature/123' + }; + github.context.payload.pull_request!.base = { + ref: 'main' + }; + }); + + describe('when a single pattern is provided', () => { + describe('and the pattern matches the head branch', () => { + it('returns true', () => { + const result = checkAllBranch(['^test'], 'head'); + expect(result).toBe(true); + }); + }); + + describe('and the pattern does not match the head branch', () => { + it('returns false', () => { + const result = checkAllBranch(['^feature/'], 'head'); + expect(result).toBe(false); + }); + }); + }); + + describe('when multiple patterns are provided', () => { + describe('and not all patterns matched', () => { + it('returns false', () => { + const result = checkAllBranch(['^test/', '^feature/'], 'head'); + expect(result).toBe(false); + }); + }); + + describe('and all patterns match', () => { + it('returns true', () => { + const result = checkAllBranch(['^test/', '/feature/'], 'head'); + expect(result).toBe(true); + }); + }); + + describe('and no patterns match', () => { + it('returns false', () => { + const result = checkAllBranch(['^feature/', '/test$'], 'head'); + expect(result).toBe(false); + }); + }); + }); + + describe('when the branch to check is specified as the base branch', () => { + describe('and the pattern matches the base branch', () => { + it('returns true', () => { + const result = checkAllBranch(['^main$'], 'base'); + expect(result).toBe(true); + }); + }); + }); +}); + +describe('checkAnyBranch', () => { + beforeEach(() => { + github.context.payload.pull_request!.head = { + ref: 'test/feature/123' + }; + github.context.payload.pull_request!.base = { + ref: 'main' + }; + }); + + describe('when a single pattern is provided', () => { + describe('and the pattern matches the head branch', () => { + it('returns true', () => { + const result = checkAnyBranch(['^test'], 'head'); + expect(result).toBe(true); + }); + }); + + describe('and the pattern does not match the head branch', () => { + it('returns false', () => { + const result = checkAnyBranch(['^feature/'], 'head'); + expect(result).toBe(false); + }); + }); + }); + + describe('when multiple patterns are provided', () => { + describe('and at least one pattern matches', () => { + it('returns true', () => { + const result = checkAnyBranch(['^test/', '^feature/'], 'head'); + expect(result).toBe(true); + }); + }); + + describe('and all patterns match', () => { + it('returns true', () => { + const result = checkAnyBranch(['^test/', '/feature/'], 'head'); + expect(result).toBe(true); + }); + }); + + describe('and no patterns match', () => { + it('returns false', () => { + const result = checkAnyBranch(['^feature/', '/test$'], 'head'); + expect(result).toBe(false); + }); + }); + }); + + describe('when the branch to check is specified as the base branch', () => { + describe('and the pattern matches the base branch', () => { + it('returns true', () => { + const result = checkAnyBranch(['^main$'], 'base'); + expect(result).toBe(true); + }); + }); + }); +}); + +describe('toBranchMatchConfig', () => { + describe('when there are no branch keys in the config', () => { + const config = {'changed-files': [{any: ['testing']}]}; + + it('returns an empty object', () => { + const result = toBranchMatchConfig(config); + expect(result).toEqual({}); + }); + }); + + describe('when the config contains a head-branch option', () => { + const config = {'head-branch': ['testing']}; + + it('sets headBranch in the matchConfig', () => { + const result = toBranchMatchConfig(config); + expect(result).toEqual({ + headBranch: ['testing'] + }); + }); + + describe('and the matching option is a string', () => { + const stringConfig = {'head-branch': 'testing'}; + + it('sets headBranch in the matchConfig', () => { + const result = toBranchMatchConfig(stringConfig); + expect(result).toEqual({ + headBranch: ['testing'] + }); + }); + }); + }); + + describe('when the config contains a base-branch option', () => { + const config = {'base-branch': ['testing']}; + it('sets baseBranch in the matchConfig', () => { + const result = toBranchMatchConfig(config); + expect(result).toEqual({ + baseBranch: ['testing'] + }); + }); + + describe('and the matching option is a string', () => { + const stringConfig = {'base-branch': 'testing'}; + + it('sets baseBranch in the matchConfig', () => { + const result = toBranchMatchConfig(stringConfig); + expect(result).toEqual({ + baseBranch: ['testing'] + }); + }); + }); + }); + + describe('when the config contains both a base-branch and head-branch option', () => { + const config = {'base-branch': ['testing'], 'head-branch': ['testing']}; + it('sets headBranch and baseBranch in the matchConfig', () => { + const result = toBranchMatchConfig(config); + expect(result).toEqual({ + baseBranch: ['testing'], + headBranch: ['testing'] + }); + }); + }); +}); diff --git a/__tests__/changedFiles.test.ts b/__tests__/changedFiles.test.ts new file mode 100644 index 000000000..0f611c5b9 --- /dev/null +++ b/__tests__/changedFiles.test.ts @@ -0,0 +1,106 @@ +import { + ChangedFilesMatchConfig, + checkAllChangedFiles, + checkAnyChangedFiles, + toChangedFilesMatchConfig +} from '../src/changedFiles'; + +jest.mock('@actions/core'); +jest.mock('@actions/github'); + +describe('checkAllChangedFiles', () => { + const changedFiles = ['foo.txt', 'bar.txt']; + + describe('when the globs match every file that has been changed', () => { + const globs = ['*.txt']; + + it('returns true', () => { + const result = checkAllChangedFiles(changedFiles, globs); + expect(result).toBe(true); + }); + }); + + describe(`when the globs don't match every file that has changed`, () => { + const globs = ['foo.txt']; + + it('returns false', () => { + const result = checkAllChangedFiles(changedFiles, globs); + expect(result).toBe(false); + }); + }); +}); + +describe('checkAnyChangedFiles', () => { + const changedFiles = ['foo.txt', 'bar.txt']; + + describe('when any glob matches any of the files that have changed', () => { + const globs = ['*.txt', '*.md']; + + it('returns true', () => { + const result = checkAnyChangedFiles(changedFiles, globs); + expect(result).toBe(true); + }); + }); + + describe('when none of the globs match any files that have changed', () => { + const globs = ['*.md']; + + it('returns false', () => { + const result = checkAnyChangedFiles(changedFiles, globs); + expect(result).toBe(false); + }); + }); +}); + +describe('toChangedFilesMatchConfig', () => { + describe(`when there is no 'changed-files' key in the config`, () => { + const config = {'head-branch': 'test'}; + + it('returns an empty object', () => { + const result = toChangedFilesMatchConfig(config); + expect(result).toEqual({}); + }); + }); + + describe(`when there is a 'changed-files' key in the config`, () => { + describe('and the value is an array of strings', () => { + const config = {'changed-files': ['testing']}; + + it('sets the value in the config object', () => { + const result = toChangedFilesMatchConfig(config); + expect(result).toEqual({ + changedFiles: ['testing'] + }); + }); + }); + + describe('and the value is a string', () => { + const config = {'changed-files': 'testing'}; + + it(`sets the string as an array in the config object`, () => { + const result = toChangedFilesMatchConfig(config); + expect(result).toEqual({ + changedFiles: ['testing'] + }); + }); + }); + + describe('but the value is an empty string', () => { + const config = {'changed-files': ''}; + + it(`returns an empty object`, () => { + const result = toChangedFilesMatchConfig(config); + expect(result).toEqual({}); + }); + }); + + describe('but the value is an empty array', () => { + const config = {'changed-files': []}; + + it(`returns an empty object`, () => { + const result = toChangedFilesMatchConfig(config); + expect(result).toEqual({}); + }); + }); + }); +}); diff --git a/__tests__/fixtures/all_options.yml b/__tests__/fixtures/all_options.yml new file mode 100644 index 000000000..f4d5ecc5f --- /dev/null +++ b/__tests__/fixtures/all_options.yml @@ -0,0 +1,14 @@ +label1: + - any: + - changed-files: ['glob'] + - head-branch: ['regexp'] + - base-branch: ['regexp'] + - all: + - changed-files: ['glob'] + - head-branch: ['regexp'] + - base-branch: ['regexp'] + +label2: + - changed-files: ['glob'] + - head-branch: ['regexp'] + - base-branch: ['regexp'] diff --git a/__tests__/fixtures/any_and_all.yml b/__tests__/fixtures/any_and_all.yml new file mode 100644 index 000000000..5b8901e5b --- /dev/null +++ b/__tests__/fixtures/any_and_all.yml @@ -0,0 +1,6 @@ +tests: + - any: + - head-branch: ['^tests/', '^test/'] + - changed-files: ['tests/**/*'] + - all: + - changed-files: ['!tests/requirements.txt'] diff --git a/__tests__/fixtures/branches.yml b/__tests__/fixtures/branches.yml new file mode 100644 index 000000000..1ad12ac6f --- /dev/null +++ b/__tests__/fixtures/branches.yml @@ -0,0 +1,11 @@ +test-branch: + - head-branch: '^test/' + +feature-branch: + - head-branch: '/feature/' + +bug-branch: + - head-branch: '^bug/|fix/' + +array-branch: + - head-branch: ['^array/'] diff --git a/__tests__/fixtures/not_supported.yml b/__tests__/fixtures/not_supported.yml new file mode 100644 index 000000000..8af7523ae --- /dev/null +++ b/__tests__/fixtures/not_supported.yml @@ -0,0 +1,3 @@ +label: + - all: + - unknown: 'this-is-not-supported' diff --git a/__tests__/fixtures/only_pdfs.yml b/__tests__/fixtures/only_pdfs.yml index 1bcce76ae..a645acfc6 100644 --- a/__tests__/fixtures/only_pdfs.yml +++ b/__tests__/fixtures/only_pdfs.yml @@ -1,2 +1,2 @@ touched-a-pdf-file: - - any: ['*.pdf'] + - changed-files: ['*.pdf'] diff --git a/__tests__/labeler.test.ts b/__tests__/labeler.test.ts index d684d28bd..0b9fb307b 100644 --- a/__tests__/labeler.test.ts +++ b/__tests__/labeler.test.ts @@ -1,6 +1,13 @@ -import {checkGlobs} from '../src/labeler'; - +import { + checkMatchConfigs, + MatchConfig, + toMatchConfig, + getLabelConfigMapFromObject, + BaseMatchConfig +} from '../src/labeler'; +import * as yaml from 'js-yaml'; import * as core from '@actions/core'; +import * as fs from 'fs'; jest.mock('@actions/core'); @@ -10,20 +17,124 @@ beforeAll(() => { }); }); -const matchConfig = [{any: ['*.txt']}]; +const loadYaml = (filepath: string) => { + const loadedFile = fs.readFileSync(filepath); + const content = Buffer.from(loadedFile).toString(); + return yaml.load(content); +}; -describe('checkGlobs', () => { - it('returns true when our pattern does match changed files', () => { - const changedFiles = ['foo.txt', 'bar.txt']; - const result = checkGlobs(changedFiles, matchConfig); +describe('getLabelConfigMapFromObject', () => { + const yamlObject = loadYaml('__tests__/fixtures/all_options.yml'); + const expected = new Map(); + expected.set('label1', [ + { + any: [ + {changedFiles: ['glob']}, + {baseBranch: undefined, headBranch: ['regexp']}, + {baseBranch: ['regexp'], headBranch: undefined} + ] + }, + { + all: [ + {changedFiles: ['glob']}, + {baseBranch: undefined, headBranch: ['regexp']}, + {baseBranch: ['regexp'], headBranch: undefined} + ] + } + ]); + expected.set('label2', [ + { + any: [ + {changedFiles: ['glob']}, + {baseBranch: undefined, headBranch: ['regexp']}, + {baseBranch: ['regexp'], headBranch: undefined} + ] + } + ]); - expect(result).toBeTruthy(); + it('returns a MatchConfig', () => { + const result = getLabelConfigMapFromObject(yamlObject); + expect(result).toEqual(expected); }); +}); + +describe('toMatchConfig', () => { + describe('when all expected config options are present', () => { + const config = { + 'changed-files': ['testing-files'], + 'head-branch': ['testing-head'], + 'base-branch': ['testing-base'] + }; + const expected: BaseMatchConfig = { + changedFiles: ['testing-files'], + headBranch: ['testing-head'], + baseBranch: ['testing-base'] + }; + + it('returns a MatchConfig object with all options', () => { + const result = toMatchConfig(config); + expect(result).toEqual(expected); + }); + + describe('and there are also unexpected options present', () => { + config['test-test'] = 'testing'; + + it('does not include the unexpected items in the returned MatchConfig object', () => { + const result = toMatchConfig(config); + expect(result).toEqual(expected); + }); + }); + }); +}); + +describe('checkMatchConfigs', () => { + describe('when a single match config is provided', () => { + const matchConfig: MatchConfig[] = [{any: [{changedFiles: ['*.txt']}]}]; + + it('returns true when our pattern does match changed files', () => { + const changedFiles = ['foo.txt', 'bar.txt']; + const result = checkMatchConfigs(changedFiles, matchConfig); + + expect(result).toBeTruthy(); + }); + + it('returns false when our pattern does not match changed files', () => { + const changedFiles = ['foo.docx']; + const result = checkMatchConfigs(changedFiles, matchConfig); + + expect(result).toBeFalsy(); + }); + + it('returns true when either the branch or changed files patter matches', () => { + const matchConfig: MatchConfig[] = [ + {any: [{changedFiles: ['*.txt']}, {headBranch: ['some-branch']}]} + ]; + const changedFiles = ['foo.txt', 'bar.txt']; + + const result = checkMatchConfigs(changedFiles, matchConfig); + expect(result).toBe(true); + }); + }); + + describe('when multiple MatchConfigs are supplied', () => { + const matchConfig: MatchConfig[] = [ + {any: [{changedFiles: ['*.txt']}]}, + {any: [{headBranch: ['some-branch']}]} + ]; + const changedFiles = ['foo.txt', 'bar.md']; - it('returns false when our pattern does not match changed files', () => { - const changedFiles = ['foo.docx']; - const result = checkGlobs(changedFiles, matchConfig); + it('returns false when only one config matches', () => { + const result = checkMatchConfigs(changedFiles, matchConfig); + expect(result).toBe(false); + }); - expect(result).toBeFalsy(); + it('returns true when only both config matches', () => { + const matchConfig: MatchConfig[] = [ + {any: [{changedFiles: ['*.txt']}]}, + {any: [{headBranch: ['head-branch']}]} + ]; + const result = checkMatchConfigs(changedFiles, matchConfig); + expect(result).toBe(true); + }); }); }); diff --git a/__tests__/main.test.ts b/__tests__/main.test.ts index ab62eae37..d5e962387 100644 --- a/__tests__/main.test.ts +++ b/__tests__/main.test.ts @@ -15,7 +15,10 @@ const paginateMock = jest.spyOn(gh, 'paginate'); const getPullMock = jest.spyOn(gh.rest.pulls, 'get'); const yamlFixtures = { - 'only_pdfs.yml': fs.readFileSync('__tests__/fixtures/only_pdfs.yml') + 'branches.yml': fs.readFileSync('__tests__/fixtures/branches.yml'), + 'only_pdfs.yml': fs.readFileSync('__tests__/fixtures/only_pdfs.yml'), + 'not_supported.yml': fs.readFileSync('__tests__/fixtures/not_supported.yml'), + 'any_and_all.yml': fs.readFileSync('__tests__/fixtures/any_and_all.yml') }; afterAll(() => jest.restoreAllMocks()); @@ -47,6 +50,14 @@ describe('run', () => { expect(addLabelsMock).toHaveBeenCalledTimes(0); }); + it('does not add a label when the match config options are not supported', async () => { + usingLabelerConfigYaml('not_supported.yml'); + await run(); + + expect(addLabelsMock).toHaveBeenCalledTimes(0); + expect(removeLabelMock).toHaveBeenCalledTimes(0); + }); + it('(with sync-labels: true) it deletes preexisting PR labels that no longer match the glob pattern', async () => { const mockInput = { 'repo-token': 'foo', @@ -102,6 +113,87 @@ describe('run', () => { expect(addLabelsMock).toHaveBeenCalledTimes(0); expect(removeLabelMock).toHaveBeenCalledTimes(0); }); + + it('adds labels based on the branch names that match the regexp pattern', async () => { + github.context.payload.pull_request!.head = {ref: 'test/testing-time'}; + usingLabelerConfigYaml('branches.yml'); + await run(); + + expect(addLabelsMock).toHaveBeenCalledTimes(1); + expect(addLabelsMock).toHaveBeenCalledWith({ + owner: 'monalisa', + repo: 'helloworld', + issue_number: 123, + labels: ['test-branch'] + }); + }); + + it('adds multiple labels based on branch names that match different regexp patterns', async () => { + github.context.payload.pull_request!.head = { + ref: 'test/feature/123' + }; + usingLabelerConfigYaml('branches.yml'); + await run(); + + expect(addLabelsMock).toHaveBeenCalledTimes(1); + expect(addLabelsMock).toHaveBeenCalledWith({ + owner: 'monalisa', + repo: 'helloworld', + issue_number: 123, + labels: ['test-branch', 'feature-branch'] + }); + }); + + it('can support multiple branches by batching', async () => { + github.context.payload.pull_request!.head = {ref: 'fix/123'}; + usingLabelerConfigYaml('branches.yml'); + await run(); + + expect(addLabelsMock).toHaveBeenCalledTimes(1); + expect(addLabelsMock).toHaveBeenCalledWith({ + owner: 'monalisa', + repo: 'helloworld', + issue_number: 123, + labels: ['bug-branch'] + }); + }); + + it('can support multiple branches by providing an array', async () => { + github.context.payload.pull_request!.head = {ref: 'array/123'}; + usingLabelerConfigYaml('branches.yml'); + await run(); + + expect(addLabelsMock).toHaveBeenCalledTimes(1); + expect(addLabelsMock).toHaveBeenCalledWith({ + owner: 'monalisa', + repo: 'helloworld', + issue_number: 123, + labels: ['array-branch'] + }); + }); + + it('adds a label when matching any and all patterns are provided', async () => { + usingLabelerConfigYaml('any_and_all.yml'); + mockGitHubResponseChangedFiles('tests/test.ts'); + await run(); + + expect(addLabelsMock).toHaveBeenCalledTimes(1); + expect(addLabelsMock).toHaveBeenCalledWith({ + owner: 'monalisa', + repo: 'helloworld', + issue_number: 123, + labels: ['tests'] + }); + }); + + it('does not add a label when not all any and all patterns are matched', async () => { + usingLabelerConfigYaml('any_and_all.yml'); + mockGitHubResponseChangedFiles('tests/requirements.txt'); + await run(); + + expect(addLabelsMock).toHaveBeenCalledTimes(0); + expect(removeLabelMock).toHaveBeenCalledTimes(0); + }); }); function usingLabelerConfigYaml(fixtureName: keyof typeof yamlFixtures): void { diff --git a/dist/index.js b/dist/index.js index b3d5dbf2a..661dd761a 100644 --- a/dist/index.js +++ b/dist/index.js @@ -1,6 +1,243 @@ /******/ (() => { // webpackBootstrap /******/ var __webpack_modules__ = ({ +/***/ 8045: +/***/ (function(__unused_webpack_module, exports, __nccwpck_require__) { + +"use strict"; + +var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) { + if (k2 === undefined) k2 = k; + var desc = Object.getOwnPropertyDescriptor(m, k); + if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) { + desc = { enumerable: true, get: function() { return m[k]; } }; + } + Object.defineProperty(o, k2, desc); +}) : (function(o, m, k, k2) { + if (k2 === undefined) k2 = k; + o[k2] = m[k]; +})); +var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) { + Object.defineProperty(o, "default", { enumerable: true, value: v }); +}) : function(o, v) { + o["default"] = v; +}); +var __importStar = (this && this.__importStar) || function (mod) { + if (mod && mod.__esModule) return mod; + var result = {}; + if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k); + __setModuleDefault(result, mod); + return result; +}; +Object.defineProperty(exports, "__esModule", ({ value: true })); +exports.checkAllBranch = exports.checkAnyBranch = exports.getBranchName = exports.toBranchMatchConfig = void 0; +const core = __importStar(__nccwpck_require__(2186)); +const github = __importStar(__nccwpck_require__(5438)); +function toBranchMatchConfig(config) { + if (!config['head-branch'] && !config['base-branch']) { + return {}; + } + const branchConfig = { + headBranch: config['head-branch'], + baseBranch: config['base-branch'] + }; + for (const branchName in branchConfig) { + if (typeof branchConfig[branchName] === 'string') { + branchConfig[branchName] = [branchConfig[branchName]]; + } + } + return branchConfig; +} +exports.toBranchMatchConfig = toBranchMatchConfig; +function getBranchName(branchBase) { + var _a, _b; + const pullRequest = github.context.payload.pull_request; + if (!pullRequest) { + return undefined; + } + if (branchBase === 'base') { + return (_a = pullRequest.base) === null || _a === void 0 ? void 0 : _a.ref; + } + else { + return (_b = pullRequest.head) === null || _b === void 0 ? void 0 : _b.ref; + } +} +exports.getBranchName = getBranchName; +function checkAnyBranch(regexps, branchBase) { + const branchName = getBranchName(branchBase); + if (!branchName) { + core.debug(` no branch name`); + return false; + } + core.debug(` checking "branch" pattern against ${branchName}`); + const matchers = regexps.map(regexp => new RegExp(regexp)); + for (const matcher of matchers) { + if (matchBranchPattern(matcher, branchName)) { + core.debug(` "branch" patterns matched against ${branchName}`); + return true; + } + } + core.debug(` "branch" patterns did not match against ${branchName}`); + return false; +} +exports.checkAnyBranch = checkAnyBranch; +function checkAllBranch(regexps, branchBase) { + const branchName = getBranchName(branchBase); + if (!branchName) { + core.debug(` cannot fetch branch name from the pull request`); + return false; + } + core.debug(` checking "branch" pattern against ${branchName}`); + const matchers = regexps.map(regexp => new RegExp(regexp)); + for (const matcher of matchers) { + if (!matchBranchPattern(matcher, branchName)) { + core.debug(` "branch" patterns did not match against ${branchName}`); + return false; + } + } + core.debug(` "branch" patterns matched against ${branchName}`); + return true; +} +exports.checkAllBranch = checkAllBranch; +function matchBranchPattern(matcher, branchName) { + core.debug(` - ${matcher}`); + if (matcher.test(branchName)) { + core.debug(` "branch" pattern matched`); + return true; + } + core.debug(` ${matcher} did not match`); + return false; +} + + +/***/ }), + +/***/ 7358: +/***/ (function(__unused_webpack_module, exports, __nccwpck_require__) { + +"use strict"; + +var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) { + if (k2 === undefined) k2 = k; + var desc = Object.getOwnPropertyDescriptor(m, k); + if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) { + desc = { enumerable: true, get: function() { return m[k]; } }; + } + Object.defineProperty(o, k2, desc); +}) : (function(o, m, k, k2) { + if (k2 === undefined) k2 = k; + o[k2] = m[k]; +})); +var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) { + Object.defineProperty(o, "default", { enumerable: true, value: v }); +}) : function(o, v) { + o["default"] = v; +}); +var __importStar = (this && this.__importStar) || function (mod) { + if (mod && mod.__esModule) return mod; + var result = {}; + if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k); + __setModuleDefault(result, mod); + return result; +}; +var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) { + function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); } + return new (P || (P = Promise))(function (resolve, reject) { + function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } } + function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } } + function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); } + step((generator = generator.apply(thisArg, _arguments || [])).next()); + }); +}; +Object.defineProperty(exports, "__esModule", ({ value: true })); +exports.checkAllChangedFiles = exports.checkAnyChangedFiles = exports.toChangedFilesMatchConfig = exports.getChangedFiles = void 0; +const core = __importStar(__nccwpck_require__(2186)); +const github = __importStar(__nccwpck_require__(5438)); +const minimatch_1 = __nccwpck_require__(2002); +function getChangedFiles(client, prNumber) { + return __awaiter(this, void 0, void 0, function* () { + const listFilesOptions = client.rest.pulls.listFiles.endpoint.merge({ + owner: github.context.repo.owner, + repo: github.context.repo.repo, + pull_number: prNumber + }); + const listFilesResponse = yield client.paginate(listFilesOptions); + const changedFiles = listFilesResponse.map((f) => f.filename); + core.debug('found changed files:'); + for (const file of changedFiles) { + core.debug(' ' + file); + } + return changedFiles; + }); +} +exports.getChangedFiles = getChangedFiles; +function toChangedFilesMatchConfig(config) { + if (!config['changed-files'] || !config['changed-files'].length) { + return {}; + } + const changedFilesConfig = config['changed-files']; + return { + changedFiles: Array.isArray(changedFilesConfig) + ? changedFilesConfig + : [changedFilesConfig] + }; +} +exports.toChangedFilesMatchConfig = toChangedFilesMatchConfig; +function printPattern(matcher) { + return (matcher.negate ? '!' : '') + matcher.pattern; +} +function isAnyMatch(changedFile, matchers) { + core.debug(` matching patterns against file ${changedFile}`); + for (const matcher of matchers) { + core.debug(` - ${printPattern(matcher)}`); + if (matcher.match(changedFile)) { + core.debug(` ${printPattern(matcher)} matched`); + return true; + } + } + core.debug(` no patterns matched`); + return false; +} +function isAllMatch(changedFile, matchers) { + core.debug(` matching patterns against file ${changedFile}`); + for (const matcher of matchers) { + core.debug(` - ${printPattern(matcher)}`); + if (!matcher.match(changedFile)) { + core.debug(` ${printPattern(matcher)} did not match`); + return false; + } + } + core.debug(` all patterns matched`); + return true; +} +function checkAnyChangedFiles(changedFiles, globs) { + const matchers = globs.map(g => new minimatch_1.Minimatch(g)); + for (const changedFile of changedFiles) { + if (isAnyMatch(changedFile, matchers)) { + core.debug(` "any" patterns matched against ${changedFile}`); + return true; + } + } + core.debug(` "any" patterns did not match any files`); + return false; +} +exports.checkAnyChangedFiles = checkAnyChangedFiles; +function checkAllChangedFiles(changedFiles, globs) { + const matchers = globs.map(g => new minimatch_1.Minimatch(g)); + for (const changedFile of changedFiles) { + if (!isAllMatch(changedFile, matchers)) { + core.debug(` "all" patterns did not match against ${changedFile}`); + return false; + } + } + core.debug(` "all" patterns matched all files`); + return true; +} +exports.checkAllChangedFiles = checkAllChangedFiles; + + +/***/ }), + /***/ 5272: /***/ (function(__unused_webpack_module, exports, __nccwpck_require__) { @@ -39,11 +276,13 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge }); }; Object.defineProperty(exports, "__esModule", ({ value: true })); -exports.checkGlobs = exports.run = void 0; +exports.checkAll = exports.checkAny = exports.checkMatchConfigs = exports.toMatchConfig = exports.getLabelConfigMapFromObject = exports.run = void 0; const core = __importStar(__nccwpck_require__(2186)); const github = __importStar(__nccwpck_require__(5438)); const yaml = __importStar(__nccwpck_require__(1917)); -const minimatch_1 = __nccwpck_require__(2002); +const changedFiles_1 = __nccwpck_require__(7358); +const branch_1 = __nccwpck_require__(8045); +const ALLOWED_CONFIG_KEYS = ['changed-files', 'head-branch', 'base-branch']; function run() { return __awaiter(this, void 0, void 0, function* () { try { @@ -62,13 +301,13 @@ function run() { pull_number: prNumber }); core.debug(`fetching changed files for pr #${prNumber}`); - const changedFiles = yield getChangedFiles(client, prNumber); - const labelGlobs = yield getLabelGlobs(client, configPath); + const changedFiles = yield (0, changedFiles_1.getChangedFiles)(client, prNumber); + const labelConfigs = yield getMatchConfigs(client, configPath); const labels = []; const labelsToRemove = []; - for (const [label, globs] of labelGlobs.entries()) { + for (const [label, configs] of labelConfigs.entries()) { core.debug(`processing ${label}`); - if (checkGlobs(changedFiles, globs)) { + if (checkMatchConfigs(changedFiles, configs)) { labels.push(label); } else if (pullRequest.labels.find(l => l.name === label)) { @@ -96,29 +335,13 @@ function getPrNumber() { } return pullRequest.number; } -function getChangedFiles(client, prNumber) { - return __awaiter(this, void 0, void 0, function* () { - const listFilesOptions = client.rest.pulls.listFiles.endpoint.merge({ - owner: github.context.repo.owner, - repo: github.context.repo.repo, - pull_number: prNumber - }); - const listFilesResponse = yield client.paginate(listFilesOptions); - const changedFiles = listFilesResponse.map((f) => f.filename); - core.debug('found changed files:'); - for (const file of changedFiles) { - core.debug(' ' + file); - } - return changedFiles; - }); -} -function getLabelGlobs(client, configurationPath) { +function getMatchConfigs(client, configurationPath) { return __awaiter(this, void 0, void 0, function* () { const configurationContent = yield fetchContent(client, configurationPath); - // loads (hopefully) a `{[label:string]: string | StringOrMatchConfig[]}`, but is `any`: + // loads (hopefully) a `{[label:string]: MatchConfig[]}`, but is `any`: const configObject = yaml.load(configurationContent); - // transform `any` => `Map` or throw if yaml is malformed: - return getLabelGlobMapFromObject(configObject); + // transform `any` => `Map` or throw if yaml is malformed: + return getLabelConfigMapFromObject(configObject); }); } function fetchContent(client, repoPath) { @@ -132,94 +355,149 @@ function fetchContent(client, repoPath) { return Buffer.from(response.data.content, response.data.encoding).toString(); }); } -function getLabelGlobMapFromObject(configObject) { - const labelGlobs = new Map(); +function getLabelConfigMapFromObject(configObject) { + const labelMap = new Map(); for (const label in configObject) { - if (typeof configObject[label] === 'string') { - labelGlobs.set(label, [configObject[label]]); - } - else if (configObject[label] instanceof Array) { - labelGlobs.set(label, configObject[label]); - } - else { - throw Error(`found unexpected type for label ${label} (should be string or array of globs)`); + const configOptions = configObject[label]; + if (!Array.isArray(configOptions) || + !configOptions.every(opts => typeof opts === 'object')) { + throw Error(`found unexpected type for label '${label}' (should be array of config options)`); + } + const matchConfigs = configOptions.reduce((updatedConfig, configValue) => { + if (!configValue) { + return updatedConfig; + } + Object.entries(configValue).forEach(([key, value]) => { + var _a; + // If the top level `any` or `all` keys are provided then set them, and convert their values to + // our config objects. + if (key === 'any' || key === 'all') { + if (Array.isArray(value)) { + const newConfigs = value.map(toMatchConfig); + updatedConfig.push({ [key]: newConfigs }); + } + } + else if (ALLOWED_CONFIG_KEYS.includes(key)) { + const newMatchConfig = toMatchConfig({ [key]: value }); + // Find or set the `any` key so that we can add these properties to that rule, + // Or create a new `any` key and add that to our array of configs. + const indexOfAny = updatedConfig.findIndex(mc => !!mc['any']); + if (indexOfAny >= 0) { + (_a = updatedConfig[indexOfAny].any) === null || _a === void 0 ? void 0 : _a.push(newMatchConfig); + } + else { + updatedConfig.push({ any: [newMatchConfig] }); + } + } + else { + // Log the key that we don't know what to do with. + core.info(`An unknown config option was under ${label}: ${key}`); + } + }); + return updatedConfig; + }, []); + if (matchConfigs.length) { + labelMap.set(label, matchConfigs); } } - return labelGlobs; + return labelMap; } +exports.getLabelConfigMapFromObject = getLabelConfigMapFromObject; function toMatchConfig(config) { - if (typeof config === 'string') { - return { - any: [config] - }; + const changedFilesConfig = (0, changedFiles_1.toChangedFilesMatchConfig)(config); + const branchConfig = (0, branch_1.toBranchMatchConfig)(config); + return Object.assign(Object.assign({}, changedFilesConfig), branchConfig); +} +exports.toMatchConfig = toMatchConfig; +function checkMatchConfigs(changedFiles, matchConfigs) { + for (const config of matchConfigs) { + core.debug(` checking config ${JSON.stringify(config)}`); + if (!checkMatch(changedFiles, config)) { + return false; + } } - return config; -} -function printPattern(matcher) { - return (matcher.negate ? '!' : '') + matcher.pattern; + return true; } -function checkGlobs(changedFiles, globs) { - for (const glob of globs) { - core.debug(` checking pattern ${JSON.stringify(glob)}`); - const matchConfig = toMatchConfig(glob); - if (checkMatch(changedFiles, matchConfig)) { - return true; +exports.checkMatchConfigs = checkMatchConfigs; +function checkMatch(changedFiles, matchConfig) { + if (!Object.keys(matchConfig).length) { + core.debug(` no "any" or "all" patterns to check`); + return false; + } + if (matchConfig.all) { + if (!checkAll(matchConfig.all, changedFiles)) { + return false; } } - return false; -} -exports.checkGlobs = checkGlobs; -function isMatch(changedFile, matchers) { - core.debug(` matching patterns against file ${changedFile}`); - for (const matcher of matchers) { - core.debug(` - ${printPattern(matcher)}`); - if (!matcher.match(changedFile)) { - core.debug(` ${printPattern(matcher)} did not match`); + if (matchConfig.any) { + if (!checkAny(matchConfig.any, changedFiles)) { return false; } } - core.debug(` all patterns matched`); return true; } // equivalent to "Array.some()" but expanded for debugging and clarity -function checkAny(changedFiles, globs) { - const matchers = globs.map(g => new minimatch_1.Minimatch(g)); +function checkAny(matchConfigs, changedFiles) { core.debug(` checking "any" patterns`); - for (const changedFile of changedFiles) { - if (isMatch(changedFile, matchers)) { - core.debug(` "any" patterns matched against ${changedFile}`); - return true; + if (!matchConfigs.length || + !matchConfigs.some(configOption => Object.keys(configOption).length)) { + core.debug(` no "any" patterns to check`); + return false; + } + for (const matchConfig of matchConfigs) { + if (matchConfig.baseBranch) { + if ((0, branch_1.checkAnyBranch)(matchConfig.baseBranch, 'base')) { + return true; + } + } + if (matchConfig.changedFiles) { + if ((0, changedFiles_1.checkAnyChangedFiles)(changedFiles, matchConfig.changedFiles)) { + return true; + } + } + if (matchConfig.headBranch) { + if ((0, branch_1.checkAnyBranch)(matchConfig.headBranch, 'head')) { + return true; + } } } - core.debug(` "any" patterns did not match any files`); + core.debug(` "any" patterns did not match any configs`); return false; } +exports.checkAny = checkAny; // equivalent to "Array.every()" but expanded for debugging and clarity -function checkAll(changedFiles, globs) { - const matchers = globs.map(g => new minimatch_1.Minimatch(g)); - core.debug(` checking "all" patterns`); - for (const changedFile of changedFiles) { - if (!isMatch(changedFile, matchers)) { - core.debug(` "all" patterns did not match against ${changedFile}`); - return false; - } +function checkAll(matchConfigs, changedFiles) { + core.debug(` checking "all" patterns`); + if (!matchConfigs.length || + !matchConfigs.some(configOption => Object.keys(configOption).length)) { + core.debug(` no "all" patterns to check`); + return false; } - core.debug(` "all" patterns matched all files`); - return true; -} -function checkMatch(changedFiles, matchConfig) { - if (matchConfig.all !== undefined) { - if (!checkAll(changedFiles, matchConfig.all)) { - return false; + for (const matchConfig of matchConfigs) { + if (matchConfig.baseBranch) { + if (!(0, branch_1.checkAllBranch)(matchConfig.baseBranch, 'base')) { + return false; + } } - } - if (matchConfig.any !== undefined) { - if (!checkAny(changedFiles, matchConfig.any)) { - return false; + if (matchConfig.changedFiles) { + if (!changedFiles.length) { + core.debug(` no files to check "changed-files" patterns against`); + return false; + } + if (!(0, changedFiles_1.checkAllChangedFiles)(changedFiles, matchConfig.changedFiles)) { + return false; + } + } + if (matchConfig.headBranch) { + if (!(0, branch_1.checkAllBranch)(matchConfig.headBranch, 'head')) { + return false; + } } } + core.debug(` "all" patterns matched all configs`); return true; } +exports.checkAll = checkAll; function addLabels(client, prNumber, labels) { return __awaiter(this, void 0, void 0, function* () { yield client.rest.issues.addLabels({ diff --git a/src/branch.ts b/src/branch.ts new file mode 100644 index 000000000..92c78186f --- /dev/null +++ b/src/branch.ts @@ -0,0 +1,98 @@ +import * as core from '@actions/core'; +import * as github from '@actions/github'; + +export interface BranchMatchConfig { + headBranch?: string[]; + baseBranch?: string[]; +} + +type BranchBase = 'base' | 'head'; + +export function toBranchMatchConfig(config: any): BranchMatchConfig { + if (!config['head-branch'] && !config['base-branch']) { + return {}; + } + + const branchConfig = { + headBranch: config['head-branch'], + baseBranch: config['base-branch'] + }; + + for (const branchName in branchConfig) { + if (typeof branchConfig[branchName] === 'string') { + branchConfig[branchName] = [branchConfig[branchName]]; + } + } + + return branchConfig; +} + +export function getBranchName(branchBase: BranchBase): string | undefined { + const pullRequest = github.context.payload.pull_request; + if (!pullRequest) { + return undefined; + } + + if (branchBase === 'base') { + return pullRequest.base?.ref; + } else { + return pullRequest.head?.ref; + } +} + +export function checkAnyBranch( + regexps: string[], + branchBase: BranchBase +): boolean { + const branchName = getBranchName(branchBase); + if (!branchName) { + core.debug(` no branch name`); + return false; + } + + core.debug(` checking "branch" pattern against ${branchName}`); + const matchers = regexps.map(regexp => new RegExp(regexp)); + for (const matcher of matchers) { + if (matchBranchPattern(matcher, branchName)) { + core.debug(` "branch" patterns matched against ${branchName}`); + return true; + } + } + + core.debug(` "branch" patterns did not match against ${branchName}`); + return false; +} + +export function checkAllBranch( + regexps: string[], + branchBase: BranchBase +): boolean { + const branchName = getBranchName(branchBase); + if (!branchName) { + core.debug(` cannot fetch branch name from the pull request`); + return false; + } + + core.debug(` checking "branch" pattern against ${branchName}`); + const matchers = regexps.map(regexp => new RegExp(regexp)); + for (const matcher of matchers) { + if (!matchBranchPattern(matcher, branchName)) { + core.debug(` "branch" patterns did not match against ${branchName}`); + return false; + } + } + + core.debug(` "branch" patterns matched against ${branchName}`); + return true; +} + +function matchBranchPattern(matcher: RegExp, branchName: string): boolean { + core.debug(` - ${matcher}`); + if (matcher.test(branchName)) { + core.debug(` "branch" pattern matched`); + return true; + } + + core.debug(` ${matcher} did not match`); + return false; +} diff --git a/src/changedFiles.ts b/src/changedFiles.ts new file mode 100644 index 000000000..cd83f3d62 --- /dev/null +++ b/src/changedFiles.ts @@ -0,0 +1,110 @@ +import * as core from '@actions/core'; +import * as github from '@actions/github'; +import {Minimatch} from 'minimatch'; + +export interface ChangedFilesMatchConfig { + changedFiles?: string[]; +} + +type ClientType = ReturnType; + +export async function getChangedFiles( + client: ClientType, + prNumber: number +): Promise { + const listFilesOptions = client.rest.pulls.listFiles.endpoint.merge({ + owner: github.context.repo.owner, + repo: github.context.repo.repo, + pull_number: prNumber + }); + + const listFilesResponse = await client.paginate(listFilesOptions); + const changedFiles = listFilesResponse.map((f: any) => f.filename); + + core.debug('found changed files:'); + for (const file of changedFiles) { + core.debug(' ' + file); + } + + return changedFiles; +} + +export function toChangedFilesMatchConfig( + config: any +): ChangedFilesMatchConfig { + if (!config['changed-files'] || !config['changed-files'].length) { + return {}; + } + + const changedFilesConfig = config['changed-files']; + + return { + changedFiles: Array.isArray(changedFilesConfig) + ? changedFilesConfig + : [changedFilesConfig] + }; +} + +function printPattern(matcher: Minimatch): string { + return (matcher.negate ? '!' : '') + matcher.pattern; +} + +function isAnyMatch(changedFile: string, matchers: Minimatch[]): boolean { + core.debug(` matching patterns against file ${changedFile}`); + for (const matcher of matchers) { + core.debug(` - ${printPattern(matcher)}`); + if (matcher.match(changedFile)) { + core.debug(` ${printPattern(matcher)} matched`); + return true; + } + } + + core.debug(` no patterns matched`); + return false; +} + +function isAllMatch(changedFile: string, matchers: Minimatch[]): boolean { + core.debug(` matching patterns against file ${changedFile}`); + for (const matcher of matchers) { + core.debug(` - ${printPattern(matcher)}`); + if (!matcher.match(changedFile)) { + core.debug(` ${printPattern(matcher)} did not match`); + return false; + } + } + + core.debug(` all patterns matched`); + return true; +} + +export function checkAnyChangedFiles( + changedFiles: string[], + globs: string[] +): boolean { + const matchers = globs.map(g => new Minimatch(g)); + for (const changedFile of changedFiles) { + if (isAnyMatch(changedFile, matchers)) { + core.debug(` "any" patterns matched against ${changedFile}`); + return true; + } + } + + core.debug(` "any" patterns did not match any files`); + return false; +} + +export function checkAllChangedFiles( + changedFiles: string[], + globs: string[] +): boolean { + const matchers = globs.map(g => new Minimatch(g)); + for (const changedFile of changedFiles) { + if (!isAllMatch(changedFile, matchers)) { + core.debug(` "all" patterns did not match against ${changedFile}`); + return false; + } + } + + core.debug(` "all" patterns matched all files`); + return true; +} diff --git a/src/labeler.ts b/src/labeler.ts index dd89044f5..7ddfe6d60 100644 --- a/src/labeler.ts +++ b/src/labeler.ts @@ -1,16 +1,32 @@ import * as core from '@actions/core'; import * as github from '@actions/github'; import * as yaml from 'js-yaml'; -import {Minimatch} from 'minimatch'; -interface MatchConfig { - all?: string[]; - any?: string[]; -} +import { + ChangedFilesMatchConfig, + getChangedFiles, + toChangedFilesMatchConfig, + checkAllChangedFiles, + checkAnyChangedFiles +} from './changedFiles'; +import { + checkAnyBranch, + checkAllBranch, + toBranchMatchConfig, + BranchMatchConfig +} from './branch'; + +export type BaseMatchConfig = BranchMatchConfig & ChangedFilesMatchConfig; + +export type MatchConfig = { + any?: BaseMatchConfig[]; + all?: BaseMatchConfig[]; +}; -type StringOrMatchConfig = string | MatchConfig; type ClientType = ReturnType; +const ALLOWED_CONFIG_KEYS = ['changed-files', 'head-branch', 'base-branch']; + export async function run() { try { const token = core.getInput('repo-token'); @@ -33,16 +49,16 @@ export async function run() { core.debug(`fetching changed files for pr #${prNumber}`); const changedFiles: string[] = await getChangedFiles(client, prNumber); - const labelGlobs: Map = await getLabelGlobs( + const labelConfigs: Map = await getMatchConfigs( client, configPath ); const labels: string[] = []; const labelsToRemove: string[] = []; - for (const [label, globs] of labelGlobs.entries()) { + for (const [label, configs] of labelConfigs.entries()) { core.debug(`processing ${label}`); - if (checkGlobs(changedFiles, globs)) { + if (checkMatchConfigs(changedFiles, configs)) { labels.push(label); } else if (pullRequest.labels.find(l => l.name === label)) { labelsToRemove.push(label); @@ -71,41 +87,20 @@ function getPrNumber(): number | undefined { return pullRequest.number; } -async function getChangedFiles( - client: ClientType, - prNumber: number -): Promise { - const listFilesOptions = client.rest.pulls.listFiles.endpoint.merge({ - owner: github.context.repo.owner, - repo: github.context.repo.repo, - pull_number: prNumber - }); - - const listFilesResponse = await client.paginate(listFilesOptions); - const changedFiles = listFilesResponse.map((f: any) => f.filename); - - core.debug('found changed files:'); - for (const file of changedFiles) { - core.debug(' ' + file); - } - - return changedFiles; -} - -async function getLabelGlobs( +async function getMatchConfigs( client: ClientType, configurationPath: string -): Promise> { +): Promise> { const configurationContent: string = await fetchContent( client, configurationPath ); - // loads (hopefully) a `{[label:string]: string | StringOrMatchConfig[]}`, but is `any`: + // loads (hopefully) a `{[label:string]: MatchConfig[]}`, but is `any`: const configObject: any = yaml.load(configurationContent); - // transform `any` => `Map` or throw if yaml is malformed: - return getLabelGlobMapFromObject(configObject); + // transform `any` => `Map` or throw if yaml is malformed: + return getLabelConfigMapFromObject(configObject); } async function fetchContent( @@ -122,110 +117,186 @@ async function fetchContent( return Buffer.from(response.data.content, response.data.encoding).toString(); } -function getLabelGlobMapFromObject( +export function getLabelConfigMapFromObject( configObject: any -): Map { - const labelGlobs: Map = new Map(); +): Map { + const labelMap: Map = new Map(); for (const label in configObject) { - if (typeof configObject[label] === 'string') { - labelGlobs.set(label, [configObject[label]]); - } else if (configObject[label] instanceof Array) { - labelGlobs.set(label, configObject[label]); - } else { + const configOptions = configObject[label]; + if ( + !Array.isArray(configOptions) || + !configOptions.every(opts => typeof opts === 'object') + ) { throw Error( - `found unexpected type for label ${label} (should be string or array of globs)` + `found unexpected type for label '${label}' (should be array of config options)` ); } - } - - return labelGlobs; -} + const matchConfigs = configOptions.reduce( + (updatedConfig, configValue) => { + if (!configValue) { + return updatedConfig; + } + + Object.entries(configValue).forEach(([key, value]) => { + // If the top level `any` or `all` keys are provided then set them, and convert their values to + // our config objects. + if (key === 'any' || key === 'all') { + if (Array.isArray(value)) { + const newConfigs = value.map(toMatchConfig); + updatedConfig.push({[key]: newConfigs}); + } + } else if (ALLOWED_CONFIG_KEYS.includes(key)) { + const newMatchConfig = toMatchConfig({[key]: value}); + // Find or set the `any` key so that we can add these properties to that rule, + // Or create a new `any` key and add that to our array of configs. + const indexOfAny = updatedConfig.findIndex(mc => !!mc['any']); + if (indexOfAny >= 0) { + updatedConfig[indexOfAny].any?.push(newMatchConfig); + } else { + updatedConfig.push({any: [newMatchConfig]}); + } + } else { + // Log the key that we don't know what to do with. + core.info(`An unknown config option was under ${label}: ${key}`); + } + }); + + return updatedConfig; + }, + [] + ); -function toMatchConfig(config: StringOrMatchConfig): MatchConfig { - if (typeof config === 'string') { - return { - any: [config] - }; + if (matchConfigs.length) { + labelMap.set(label, matchConfigs); + } } - return config; + return labelMap; } -function printPattern(matcher: Minimatch): string { - return (matcher.negate ? '!' : '') + matcher.pattern; +export function toMatchConfig(config: any): BaseMatchConfig { + const changedFilesConfig = toChangedFilesMatchConfig(config); + const branchConfig = toBranchMatchConfig(config); + + return { + ...changedFilesConfig, + ...branchConfig + }; } -export function checkGlobs( +export function checkMatchConfigs( changedFiles: string[], - globs: StringOrMatchConfig[] + matchConfigs: MatchConfig[] ): boolean { - for (const glob of globs) { - core.debug(` checking pattern ${JSON.stringify(glob)}`); - const matchConfig = toMatchConfig(glob); - if (checkMatch(changedFiles, matchConfig)) { - return true; + for (const config of matchConfigs) { + core.debug(` checking config ${JSON.stringify(config)}`); + if (!checkMatch(changedFiles, config)) { + return false; } } - return false; + + return true; } -function isMatch(changedFile: string, matchers: Minimatch[]): boolean { - core.debug(` matching patterns against file ${changedFile}`); - for (const matcher of matchers) { - core.debug(` - ${printPattern(matcher)}`); - if (!matcher.match(changedFile)) { - core.debug(` ${printPattern(matcher)} did not match`); +function checkMatch(changedFiles: string[], matchConfig: MatchConfig): boolean { + if (!Object.keys(matchConfig).length) { + core.debug(` no "any" or "all" patterns to check`); + return false; + } + + if (matchConfig.all) { + if (!checkAll(matchConfig.all, changedFiles)) { + return false; + } + } + + if (matchConfig.any) { + if (!checkAny(matchConfig.any, changedFiles)) { return false; } } - core.debug(` all patterns matched`); return true; } // equivalent to "Array.some()" but expanded for debugging and clarity -function checkAny(changedFiles: string[], globs: string[]): boolean { - const matchers = globs.map(g => new Minimatch(g)); +export function checkAny( + matchConfigs: BaseMatchConfig[], + changedFiles: string[] +): boolean { core.debug(` checking "any" patterns`); - for (const changedFile of changedFiles) { - if (isMatch(changedFile, matchers)) { - core.debug(` "any" patterns matched against ${changedFile}`); - return true; + if ( + !matchConfigs.length || + !matchConfigs.some(configOption => Object.keys(configOption).length) + ) { + core.debug(` no "any" patterns to check`); + return false; + } + + for (const matchConfig of matchConfigs) { + if (matchConfig.baseBranch) { + if (checkAnyBranch(matchConfig.baseBranch, 'base')) { + return true; + } + } + + if (matchConfig.changedFiles) { + if (checkAnyChangedFiles(changedFiles, matchConfig.changedFiles)) { + return true; + } + } + + if (matchConfig.headBranch) { + if (checkAnyBranch(matchConfig.headBranch, 'head')) { + return true; + } } } - core.debug(` "any" patterns did not match any files`); + core.debug(` "any" patterns did not match any configs`); return false; } // equivalent to "Array.every()" but expanded for debugging and clarity -function checkAll(changedFiles: string[], globs: string[]): boolean { - const matchers = globs.map(g => new Minimatch(g)); - core.debug(` checking "all" patterns`); - for (const changedFile of changedFiles) { - if (!isMatch(changedFile, matchers)) { - core.debug(` "all" patterns did not match against ${changedFile}`); - return false; - } +export function checkAll( + matchConfigs: BaseMatchConfig[], + changedFiles: string[] +): boolean { + core.debug(` checking "all" patterns`); + if ( + !matchConfigs.length || + !matchConfigs.some(configOption => Object.keys(configOption).length) + ) { + core.debug(` no "all" patterns to check`); + return false; } - core.debug(` "all" patterns matched all files`); - return true; -} + for (const matchConfig of matchConfigs) { + if (matchConfig.baseBranch) { + if (!checkAllBranch(matchConfig.baseBranch, 'base')) { + return false; + } + } -function checkMatch(changedFiles: string[], matchConfig: MatchConfig): boolean { - if (matchConfig.all !== undefined) { - if (!checkAll(changedFiles, matchConfig.all)) { - return false; + if (matchConfig.changedFiles) { + if (!changedFiles.length) { + core.debug(` no files to check "changed-files" patterns against`); + return false; + } + + if (!checkAllChangedFiles(changedFiles, matchConfig.changedFiles)) { + return false; + } } - } - if (matchConfig.any !== undefined) { - if (!checkAny(changedFiles, matchConfig.any)) { - return false; + if (matchConfig.headBranch) { + if (!checkAllBranch(matchConfig.headBranch, 'head')) { + return false; + } } } + core.debug(` "all" patterns matched all configs`); return true; }