From 4caff3c95e86176f41af1b58320c57ae6b47bfdb Mon Sep 17 00:00:00 2001 From: Yang Cao Date: Fri, 10 May 2024 10:41:37 -0400 Subject: [PATCH] Also do not give up when uploading steps metadata --- src/Runner.Common/JobServerQueue.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Runner.Common/JobServerQueue.cs b/src/Runner.Common/JobServerQueue.cs index e489ff2029f..dd060734b79 100644 --- a/src/Runner.Common/JobServerQueue.cs +++ b/src/Runner.Common/JobServerQueue.cs @@ -709,7 +709,9 @@ private async Task ProcessTimelinesUpdateQueueAsync(bool runOnce = false) { Trace.Info("Catch exception during update steps, skip update Results."); Trace.Error(e); - if (!_resultsServiceOnly) + _resultsServiceExceptionsCount++; + // If we hit any exceptions uploading to Results, let's skip any additional uploads to Results unless Results is serving logs + if (!_resultsServiceOnly && _resultsServiceExceptionsCount > 3) { _resultsClientInitiated = false; SendResultsTelemetry(e);