Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JetBrainsRuntime distribution #399

Closed
Syer10 opened this issue Nov 4, 2022 · 15 comments · Fixed by #637
Closed

Support JetBrainsRuntime distribution #399

Syer10 opened this issue Nov 4, 2022 · 15 comments · Fixed by #637
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@Syer10
Copy link

Syer10 commented Nov 4, 2022

Description:
Add support for JetBrainsRuntime Java distribution https://github.com/JetBrains/JetBrainsRuntime/

Justification:
I build a desktop app using Compose Multiplatform, and the best distribution to use when building/packaging it is JetBrains Runtime because it expands the runtime support for GUI apps, expanding Swing and AWT support for every platform and fixing bugs. I use Github Actions to build my app so having it be supported in this action would be very helpful.

Are you willing to submit a PR?
Im not familair with TypeScript/JavaScript so I cannot say yes.

@Syer10 Syer10 added feature request New feature or request to improve the current logic needs triage labels Nov 4, 2022
@Syer10 Syer10 changed the title Support JetbrainsRuntime distribution Support JetBrainsRuntime distribution Nov 4, 2022
@marko-zivic-93
Copy link
Contributor

marko-zivic-93 commented Nov 4, 2022

Hello @Syer10
Thank you for your feature request. We will investigate this and come back to you as soon as possible :)

@panticmilos panticmilos self-assigned this Nov 8, 2022
@panticmilos
Copy link
Contributor

hi @Syer10, after the consultation with the team we have decided we are not currently planning to implement this feature. But I will not close this issue, because we want to see how much attention it is going to get :)

@yeikel
Copy link

yeikel commented Feb 16, 2023

@panticmilos Would you accept community contributions for this? If so, feel free to assign this to me

@jsoref
Copy link

jsoref commented Mar 6, 2023

It doesn't seem like they'd accept a community contribution without first showing demand.

But you could make a fork that included it and the evidence of repositories using your fork would be a good way to convince them to integrate it.

@panticmilos
Copy link
Contributor

hi @yeikel, sorry for the delayed response. We are still not going to close this feature request, but still keeping it open for same reasons that I mentioned in the comment above :)

@nicbell
Copy link

nicbell commented Apr 18, 2023

This sounds like a good idea especially for Android projects as it will match Android Studio.

@SingingBush
Copy link

I'd certainly like setup-java to support jbr as a distribution. It's worth doing for people that produce plugins for Jetbrains IDE's.

@jsoref
Copy link

jsoref commented Jul 20, 2023

@yeikel why not create a branch in your fork that adds the support and then link to it here. We'll be able to see how much your repository is used pretty easily (GitHub tracks dependencies).

@yeikel
Copy link

yeikel commented Jul 20, 2023

@yeikel why not create a branch in your fork that adds the support and then link to it here. We'll be able to see how much your repository is used pretty easily (GitHub tracks dependencies).

My intention was to contribute to this project in general, and I saw an issue I could try

I have no particular interest or need to support this runtime, and maintaining a fork is not something I am interested at this time

@jsoref
Copy link

jsoref commented Jul 20, 2023

🤷

There's no obligation to maintain your fork. This repository doesn't have high churn and you aren't obligated to support it.

For anyone curious, adding support for a distribution really doesn't look particularly hard, you basically implement two files installer.js and model.js and then add some references. Here's an example:
5ffc13f

Once you've gotten it working in your fork, you can advertise it here.

Once it's advertised, you can look at the equivalent of this to see how much your version is used:
https://github.com/actions/setup-java/network/dependents

For example:
https://github.com/jord1e/setup-java/network/dependents

@MessiasLima
Copy link

Would be nice to have thin in GitHub actions

@rock3r
Copy link

rock3r commented Jan 30, 2024

Would it be possible to re-consider this, especially now that FooJay discover APIs support the JetBrains Runtime? It's very useful for Compose Multiplatform projects such as Jewel.

@gmitch215
Copy link
Contributor

gmitch215 commented Jun 28, 2024

This is a little late, but I submitted a PR that adds support for this:

- name: Setup JBR 21
  uses: gmitch215/setup-java@6d2c5e1f82f180ae79f799f0ed6e3e5efb4e664d
  with:
    distribution: 'jetbrains'
    java-version: 21
    cache: 'gradle'
  # For GitHub API (use if you believe you'd run into rate limits)
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@apolostudio
Copy link

any news on this?

@gmitch215
Copy link
Contributor

See #637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

14 participants