-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize cache download timeout #509
Comments
Hi, @mrmeyers99 👋 Thanks for the feature request, we will take a look on it and get back to you with updates. |
+1, I would also like to customize the timeout. The default is 1h, which is excessive IMHO. I have some GH Actions that take just 10m even without the cache, so it makes no sense to wait 1h. I would probably set the timeout at 1m if it were configurable. |
A built in retry world be nice as well. |
Hi, @FelixGV and @mrmeyers99, thanks for the feature request. As of version v3.2.1 of the package @actions/cache it's possible to control cache segment restore timeout https://github.com/actions/toolkit/tree/main/packages/cache#cache-segment-restore-timeout. This package is used under the hood of our action. Instead of providing a similar functionality, I'd better update version of the @actions/cache to v3.2.1 and add information about this possibility into the README.md. What do you think? |
Great, thanks @IvanZosimov, we can try that out. |
Thanks, I'll ping you when the update of the @actions/cache to v3.2.1 is done. |
Oh ok it's not done yet, I had misunderstood. Sounds good, LMK then. |
Hi, @FelixGV and @mrmeyers99 👋 The PR with changes related to this issue is merged, as soon as the new version of setup-java is released, I'll ping you. |
Hi, @FelixGV and @mrmeyers99 👋 , the new |
Description:
I would like to be able to set a max time limit that it will spend downloading dependencies. If the download exceeds this time, then it would put a warning in the logs, but then proceed without a cache.
Justification:
Our project has a fairly large (4.5gb) maven cache and for some reason every once in a while the download will go really slow. I'm not sure if it's a problem on our self-hosted runner or on github's side, but it seems there's a built in time out for an hour. That's a really long time to wait for the cache to download. It normally takes about 80 seconds to download.
Are you willing to submit a PR?
Probably not
The text was updated successfully, but these errors were encountered: