Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: update the java-version list #557

Closed
ghost opened this issue Nov 17, 2023 · 7 comments · Fixed by #566
Closed

README: update the java-version list #557

ghost opened this issue Nov 17, 2023 · 7 comments · Fixed by #566
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@ghost
Copy link

ghost commented Nov 17, 2023

Description:
Java LTS version 21 has been available for some time now, but the repository is still not updated.

Justification:
Version 21 deserves to be in the list as an LTS version.

Are you willing to submit a PR?
No, sorry.

@ghost ghost added feature request New feature or request to improve the current logic needs triage labels Nov 17, 2023
@SethTisue
Copy link

Doesn't it already work? I'm using it at e.g. https://github.com/SethTisue/Project-Euler/blob/main/.github/workflows/ci.yml and in a number of other repos I do work in.

@ghost
Copy link
Author

ghost commented Nov 18, 2023

Doesn't it already work? I'm using it at e.g. https://github.com/SethTisue/Project-Euler/blob/main/.github/workflows/ci.yml and in a number of other repos I do work in.

Yes, it can be used. It just hasn't been tested.

It's also not in the README, but you do have access to it.

@IvanZosimov IvanZosimov added documentation Improvements or additions to documentation and removed needs triage feature request New feature or request to improve the current logic labels Nov 20, 2023
@IvanZosimov
Copy link
Contributor

Hi, @exhviewer 👋 As @SethTisue mentioned, Temurin 21 can be set up in the current version of setup-java. Nevertheless, thank you for the issue, we will update documentation.

@ghost ghost changed the title Support Eclipse Temurin 21 README: update the java-version list Nov 20, 2023
@Khant-NyarxG-Next
Copy link

i want to make with kotlin
compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}

i try so many way but don't worked

image

@IvanZosimov IvanZosimov self-assigned this Nov 23, 2023
@IvanZosimov
Copy link
Contributor

Hi, @Khant-NyarxG-Next 👋 Could you please create a new issue with the full context? Currently, it's not quite clear what problem you're trying to report.

@Khant-NyarxG-Next
Copy link

Khant-NyarxG-Next commented Nov 23, 2023

Hi, @Khant-NyarxG-Next 👋 Could you please create a new issue with the full context? Currently, it's not quite clear what problem you're trying to report.

thanks for response but i have been solve the problem .i create ci for my kotlin app and in yout docs i don't find the correct version of java and i found the solution from somewhere and it worked with
distribution: temurin
java-version: 21

@AleksandarTokarev
Copy link

It would be great if the README is updated with Java 21 - so people are not mislead that it does not work with Java 21.

Okeanos added a commit to Okeanos/setup-java that referenced this issue Dec 9, 2023
Update examples and references to Java where older Java versions are used to
highlight the support of Java 21.

Specific provider examples are only updated where they support Java 21.

Fixes actions#557
IvanZosimov pushed a commit that referenced this issue Dec 14, 2023
Update examples and references to Java where older Java versions are used to
highlight the support of Java 21.

Specific provider examples are only updated where they support Java 21.

Fixes #557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants