Add java-package parameter to action, support jre, jdk, and jdk+fx #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add java-package parameter to action, support jre, jdk, and jdk+fx (#1) * Update tests to use 'jdk', 'jre', and 'jdk+fx' javaPackage parameters * Match extension only at end of line * Update README.md * Update workflow to use 'node-version' instead of deprecated 'version'
This was referenced Nov 3, 2019
giltene
commented
Nov 13, 2019
|
Note that in addition to adding the option to specify jre and jdk-fx packages addressing #18, the change to match extension names only at the end of line fur file name (makes sure to ignore e.g. .tar.gz.sig) addresses the things that have caused #23 , so that .sig files can be safely added to the cdn without breaking actions/setup-java |
konradpabjan
approved these changes
Nov 22, 2019
|
Thanks for getting these changes in! 😃 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for multiple Java package types: jre, jdk, and jdk+fx. In addition to the [updated] built-in tests, this change has been tested against a wide range of Java versions and package type combinations that exist on the Zulu community cdn, verifying that existing jdk (default) behavior remains the same, and new package types (jre, jdk+fx) work as well on versions for which they are available in the cdn.
Add java-package option to action, support jre, jdk, and jdk+fx (Features/installer #1)
Update tests to use 'jdk', 'jre', and 'jdk+fx' java package option, as well as test with invalid package
Match extension only at end of line (e.g. ignore .tar.gz.sig files in cdn).
Update README.md
Update workflow to use 'node-version' instead of deprecated 'version'