Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions properties to cache #280

Merged

Conversation

Endi327
Copy link
Contributor

@Endi327 Endi327 commented Jan 17, 2022

Description:
When using refreshVersions plugin, all the versions are managed in one particular file called versions.properties. This file is created by the plugin in the root directory and only used for handling versions in one place. As you can see they have quite a huge user base, so this would help a lot of users.

This PR adds the files **/versions.properties to the cache key calculation (in addition to the existing **/.gradle, **/gradle-wrapper.properties).

Related issue:
None.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov
Copy link
Contributor

Hello @Endi327. Thank you for your pull request. I think it looks good, just some minor questions.

@Endi327
Copy link
Contributor Author

Endi327 commented Jan 20, 2022

Hello @dmitry-shibanov. Thank you for your reply. Let me answer your questions:

@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Jan 24, 2022

Hello @Endi327. Thank you for your response. About the second question I'm just curious about it because I do not want to cause constant saving of the cache. It'll lead to the longer builds. How often will the ./gradlew refreshVersions command be used ?
I'll test with your changes. For now I'll start up checks on the CI.
Thank you!

@dmitry-shibanov
Copy link
Contributor

Could you please run the npm run format command.

npm run format change
@Endi327
Copy link
Contributor Author

Endi327 commented Jan 24, 2022

@dmitry-shibanov It is depending on the team/developer. It is possible that it will run every time before creating a new pull request, but the file will only change if the task find a new available version for one of the 3rd party dependencies. So there is no exact method to count the frequency because all dependency has its own schedule for updates. We will create an action to run it every two weeks.
I updated my project with a fix, please use the latest commit (b271e04ed9d60ce8042a7c5cfbedfa2584d48d50) as head on feature/refreshVersion.
I also updated my pull request with the lint fix, npm run format pointed out the issue.

@Endi327
Copy link
Contributor Author

Endi327 commented Jan 28, 2022

@dmitry-shibanov Updated the unit tests so now all checks have passed.

@Endi327
Copy link
Contributor Author

Endi327 commented Apr 6, 2022

@dmitry-shibanov Is there any update on this?

@dmitry-shibanov
Copy link
Contributor

Hello @Endi327. Sorry for the late response. Could you please sync with the main branch ?

@IvanZosimov IvanZosimov self-requested a review July 20, 2023 07:59
@IvanZosimov IvanZosimov self-assigned this Jul 20, 2023
@IvanZosimov IvanZosimov requested a review from a team as a code owner July 20, 2023 10:29
@IvanZosimov IvanZosimov removed their request for review July 20, 2023 10:30
@IvanZosimov IvanZosimov requested a review from dsame July 20, 2023 12:12
@IvanZosimov IvanZosimov merged commit cd89f46 into actions:main Jul 21, 2023
ianlewis referenced this pull request in slsa-framework/slsa-github-generator Aug 1, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| actions/setup-java | action | digest | `cd89f46` -> `b943a4e` |
| [actions/setup-java](https://github.com/actions/setup-java) | action
| minor | `v3.11.0` -> `v3.12.0` |
| [actions/setup-java](https://github.com/actions/setup-java) | action
| digest | `5ffc13f` -> `cd89f46` |
| [github/codeql-action](https://github.com/github/codeql-action) |
action | patch | `v2.21.0` -> `v2.21.2` |
|
[gradle/gradle-build-action](https://github.com/gradle/gradle-build-action)
| action | minor | `v2.6.1` -> `v2.7.0` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>actions/setup-java (actions/setup-java)</summary>

###
[`v3.12.0`](https://github.com/actions/setup-java/releases/tag/v3.12.0)

[Compare
Source](https://github.com/actions/setup-java/compare/v3.11.0...v3.12.0)

In scope of this release the following changes were made:

**Bug fixes:**

- Always check postfix "Contents/Home" on macOS by
[@&#8203;erwin1](https://github.com/erwin1) in
[https://github.com/actions/setup-java/pull/397](https://github.com/actions/setup-java/pull/397)
- Fix sbt/scala cache key by
[@&#8203;Dogacel](https://github.com/Dogacel) in
[https://github.com/actions/setup-java/pull/478](https://github.com/actions/setup-java/pull/478)
- Corretto toolcache folder name fix by
[@&#8203;IvanZosimov](https://github.com/IvanZosimov) in
[https://github.com/actions/setup-java/pull/480](https://github.com/actions/setup-java/pull/480)
- Update versions of Oracle JDK and Microsoft Build of OpenJDK by
[@&#8203;anishi1222](https://github.com/anishi1222) in
[https://github.com/actions/setup-java/pull/489](https://github.com/actions/setup-java/pull/489)
- Update Oracle JDK download URL calculation by
[@&#8203;nikolai-laevskii](https://github.com/nikolai-laevskii) in
[https://github.com/actions/setup-java/pull/507](https://github.com/actions/setup-java/pull/507)

**Feature implementations:**

- Add versions properties to cache by
[@&#8203;Endi327](https://github.com/Endi327) in
[https://github.com/actions/setup-java/pull/280](https://github.com/actions/setup-java/pull/280)

**Resolving dependencies issues:**

- Remove implicit dependencies by
[@&#8203;nikolai-laevskii](https://github.com/nikolai-laevskii) in
[https://github.com/actions/setup-java/pull/494](https://github.com/actions/setup-java/pull/494)
- Update xml2js by
[@&#8203;dmitry-shibanov](https://github.com/dmitry-shibanov) in
[https://github.com/actions/setup-java/pull/484](https://github.com/actions/setup-java/pull/484)
- Update dependencies by
[@&#8203;IvanZosimov](https://github.com/IvanZosimov) in
[https://github.com/actions/setup-java/pull/511](https://github.com/actions/setup-java/pull/511)

**Infrastructure updates:**

- Fix glob bug in package.json scripts section by
[@&#8203;IvanZosimov](https://github.com/IvanZosimov) in
[https://github.com/actions/setup-java/pull/475](https://github.com/actions/setup-java/pull/475)
- Update mocks by
[@&#8203;nikolai-laevskii](https://github.com/nikolai-laevskii) in
[https://github.com/actions/setup-java/pull/498](https://github.com/actions/setup-java/pull/498)

**Documentation changes:**

- Instruction to download custom distribution JDK and install by
[@&#8203;ragsmpl](https://github.com/ragsmpl) in
[https://github.com/actions/setup-java/pull/500](https://github.com/actions/setup-java/pull/500)

#### New Contributors

- [@&#8203;erwin1](https://github.com/erwin1) made their first
contribution in
[https://github.com/actions/setup-java/pull/397](https://github.com/actions/setup-java/pull/397)
- [@&#8203;Dogacel](https://github.com/Dogacel) made their first
contribution in
[https://github.com/actions/setup-java/pull/478](https://github.com/actions/setup-java/pull/478)
- [@&#8203;anishi1222](https://github.com/anishi1222) made their first
contribution in
[https://github.com/actions/setup-java/pull/489](https://github.com/actions/setup-java/pull/489)
- [@&#8203;nikolai-laevskii](https://github.com/nikolai-laevskii) made
their first contribution in
[https://github.com/actions/setup-java/pull/498](https://github.com/actions/setup-java/pull/498)
- [@&#8203;ragsmpl](https://github.com/ragsmpl) made their first
contribution in
[https://github.com/actions/setup-java/pull/500](https://github.com/actions/setup-java/pull/500)
- [@&#8203;Endi327](https://github.com/Endi327) made their first
contribution in
[https://github.com/actions/setup-java/pull/280](https://github.com/actions/setup-java/pull/280)

**Full Changelog**:
actions/setup-java@v3...v3.12.0

</details>

<details>
<summary>github/codeql-action (github/codeql-action)</summary>

###
[`v2.21.2`](https://github.com/github/codeql-action/compare/v2.21.1...v2.21.2)

[Compare
Source](https://github.com/github/codeql-action/compare/v2.21.1...v2.21.2)

###
[`v2.21.1`](https://github.com/github/codeql-action/compare/v2.21.0...v2.21.1)

[Compare
Source](https://github.com/github/codeql-action/compare/v2.21.0...v2.21.1)

</details>

<details>
<summary>gradle/gradle-build-action
(gradle/gradle-build-action)</summary>

###
[`v2.7.0`](https://github.com/gradle/gradle-build-action/releases/tag/v2.7.0)

[Compare
Source](https://github.com/gradle/gradle-build-action/compare/v2.6.1...v2.7.0)

##### GitHub Dependency Graph support

In this release, the GitHub Dependency Graph support is no longer
considered "experimental", and should be considered ready for production
use. You can read more about the Dependency Graph support in [the README
chapter](https://github.com/gradle/gradle-build-action#github-dependency-graph-support).

##### Changes

- Update to
[`github-dependency-graph-gradle-plugin@v0.2.0`](https://plugins.gradle.org/plugin/org.gradle.github-dependency-graph-gradle-plugin/0.2.0)
- Dependency graph uses Gradle Settings file as manifest location (if
Settings file exists)
- Adds a `dependency-graph-file` output to any step that generates a
Dependency Graph file

##### Changelog

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/slsa-framework/slsa-github-generator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Signed-off-by: Mend Renovate <bot@renovateapp.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Co-authored-by: Ian Lewis <ianlewis@google.com>
enteraga6 referenced this pull request in enteraga6/slsa-github-generator Aug 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| actions/setup-java | action | digest | `cd89f46` -> `b943a4e` |
| [actions/setup-java](https://github.com/actions/setup-java) | action
| minor | `v3.11.0` -> `v3.12.0` |
| [actions/setup-java](https://github.com/actions/setup-java) | action
| digest | `5ffc13f` -> `cd89f46` |
| [github/codeql-action](https://github.com/github/codeql-action) |
action | patch | `v2.21.0` -> `v2.21.2` |
|
[gradle/gradle-build-action](https://github.com/gradle/gradle-build-action)
| action | minor | `v2.6.1` -> `v2.7.0` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>actions/setup-java (actions/setup-java)</summary>

###
[`v3.12.0`](https://github.com/actions/setup-java/releases/tag/v3.12.0)

[Compare
Source](https://github.com/actions/setup-java/compare/v3.11.0...v3.12.0)

In scope of this release the following changes were made:

**Bug fixes:**

- Always check postfix "Contents/Home" on macOS by
[@&#8203;erwin1](https://github.com/erwin1) in
[https://github.com/actions/setup-java/pull/397](https://github.com/actions/setup-java/pull/397)
- Fix sbt/scala cache key by
[@&#8203;Dogacel](https://github.com/Dogacel) in
[https://github.com/actions/setup-java/pull/478](https://github.com/actions/setup-java/pull/478)
- Corretto toolcache folder name fix by
[@&#8203;IvanZosimov](https://github.com/IvanZosimov) in
[https://github.com/actions/setup-java/pull/480](https://github.com/actions/setup-java/pull/480)
- Update versions of Oracle JDK and Microsoft Build of OpenJDK by
[@&#8203;anishi1222](https://github.com/anishi1222) in
[https://github.com/actions/setup-java/pull/489](https://github.com/actions/setup-java/pull/489)
- Update Oracle JDK download URL calculation by
[@&#8203;nikolai-laevskii](https://github.com/nikolai-laevskii) in
[https://github.com/actions/setup-java/pull/507](https://github.com/actions/setup-java/pull/507)

**Feature implementations:**

- Add versions properties to cache by
[@&#8203;Endi327](https://github.com/Endi327) in
[https://github.com/actions/setup-java/pull/280](https://github.com/actions/setup-java/pull/280)

**Resolving dependencies issues:**

- Remove implicit dependencies by
[@&#8203;nikolai-laevskii](https://github.com/nikolai-laevskii) in
[https://github.com/actions/setup-java/pull/494](https://github.com/actions/setup-java/pull/494)
- Update xml2js by
[@&#8203;dmitry-shibanov](https://github.com/dmitry-shibanov) in
[https://github.com/actions/setup-java/pull/484](https://github.com/actions/setup-java/pull/484)
- Update dependencies by
[@&#8203;IvanZosimov](https://github.com/IvanZosimov) in
[https://github.com/actions/setup-java/pull/511](https://github.com/actions/setup-java/pull/511)

**Infrastructure updates:**

- Fix glob bug in package.json scripts section by
[@&#8203;IvanZosimov](https://github.com/IvanZosimov) in
[https://github.com/actions/setup-java/pull/475](https://github.com/actions/setup-java/pull/475)
- Update mocks by
[@&#8203;nikolai-laevskii](https://github.com/nikolai-laevskii) in
[https://github.com/actions/setup-java/pull/498](https://github.com/actions/setup-java/pull/498)

**Documentation changes:**

- Instruction to download custom distribution JDK and install by
[@&#8203;ragsmpl](https://github.com/ragsmpl) in
[https://github.com/actions/setup-java/pull/500](https://github.com/actions/setup-java/pull/500)

#### New Contributors

- [@&#8203;erwin1](https://github.com/erwin1) made their first
contribution in
[https://github.com/actions/setup-java/pull/397](https://github.com/actions/setup-java/pull/397)
- [@&#8203;Dogacel](https://github.com/Dogacel) made their first
contribution in
[https://github.com/actions/setup-java/pull/478](https://github.com/actions/setup-java/pull/478)
- [@&#8203;anishi1222](https://github.com/anishi1222) made their first
contribution in
[https://github.com/actions/setup-java/pull/489](https://github.com/actions/setup-java/pull/489)
- [@&#8203;nikolai-laevskii](https://github.com/nikolai-laevskii) made
their first contribution in
[https://github.com/actions/setup-java/pull/498](https://github.com/actions/setup-java/pull/498)
- [@&#8203;ragsmpl](https://github.com/ragsmpl) made their first
contribution in
[https://github.com/actions/setup-java/pull/500](https://github.com/actions/setup-java/pull/500)
- [@&#8203;Endi327](https://github.com/Endi327) made their first
contribution in
[https://github.com/actions/setup-java/pull/280](https://github.com/actions/setup-java/pull/280)

**Full Changelog**:
actions/setup-java@v3...v3.12.0

</details>

<details>
<summary>github/codeql-action (github/codeql-action)</summary>

###
[`v2.21.2`](https://github.com/github/codeql-action/compare/v2.21.1...v2.21.2)

[Compare
Source](https://github.com/github/codeql-action/compare/v2.21.1...v2.21.2)

###
[`v2.21.1`](https://github.com/github/codeql-action/compare/v2.21.0...v2.21.1)

[Compare
Source](https://github.com/github/codeql-action/compare/v2.21.0...v2.21.1)

</details>

<details>
<summary>gradle/gradle-build-action
(gradle/gradle-build-action)</summary>

###
[`v2.7.0`](https://github.com/gradle/gradle-build-action/releases/tag/v2.7.0)

[Compare
Source](https://github.com/gradle/gradle-build-action/compare/v2.6.1...v2.7.0)

##### GitHub Dependency Graph support

In this release, the GitHub Dependency Graph support is no longer
considered "experimental", and should be considered ready for production
use. You can read more about the Dependency Graph support in [the README
chapter](https://github.com/gradle/gradle-build-action#github-dependency-graph-support).

##### Changes

- Update to
[`github-dependency-graph-gradle-plugin@v0.2.0`](https://plugins.gradle.org/plugin/org.gradle.github-dependency-graph-gradle-plugin/0.2.0)
- Dependency graph uses Gradle Settings file as manifest location (if
Settings file exists)
- Adds a `dependency-graph-file` output to any step that generates a
Dependency Graph file

##### Changelog

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/slsa-framework/slsa-github-generator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Signed-off-by: Mend Renovate <bot@renovateapp.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <elzner@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants