Update versions of Oracle JDK and Microsoft Build of OpenJDK #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narcos1976
approved these changes
May 6, 2023
Narcos1976
approved these changes
May 6, 2023
|
Additionally e2e-versions.yml was updated. Please review it. |
IvanZosimov
suggested changes
May 9, 2023
| "version": "17.0.3", | ||
| "version": "17.0.7", |
There was a problem hiding this comment.
May I ask you not to remove old versions but add new versions for 17 and also for 11 JDKS ? For instance the last version of JDK 17 that was added to the microsoft-openjdk-versions.json is 17.0.3. May I ask you to add not only 17.0.7 but also versions from 17.0.4 to 17.0.6. Current LTS links you can find here, links to the previous versions can be found here. You will need to update the unit-tests after that again.
|
Hi, @anishi1222 👋 Thanks for the update! I left some comments, please take a look. |
Following Ivan's comment, versions of JDK are added.
Anishi1222 patch 1
|
Hi, @anishi1222 👋 Thanks for the update! I think for the unit-tests it'd be better to create mock .json file in order not to change the unit-tests every time when a new version is added. We did the same for adopt and other distributions, you can check example here. May I ask you to do this? |
|
@IvanZosimov, thank you for your comment. Sure, I'll do that. |
0xETHengineer
approved these changes
May 25, 2023
2 tasks
IvanZosimov
approved these changes
Jun 7, 2023
|
Hi, @anishi1222 👋 , thanks again for this PR ❤️ I'd like to inform you that from your side there is no need to add changes suggested in #489 (comment) as we did it by ourselves in #498 . Your PR will be merged very soon. |
ianlewis
referenced
this pull request
in slsa-framework/slsa-github-generator
Aug 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | actions/setup-java | action | digest | `cd89f46` -> `b943a4e` | | [actions/setup-java](https://github.com/actions/setup-java) | action | minor | `v3.11.0` -> `v3.12.0` | | [actions/setup-java](https://github.com/actions/setup-java) | action | digest | `5ffc13f` -> `cd89f46` | | [github/codeql-action](https://github.com/github/codeql-action) | action | patch | `v2.21.0` -> `v2.21.2` | | [gradle/gradle-build-action](https://github.com/gradle/gradle-build-action) | action | minor | `v2.6.1` -> `v2.7.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/setup-java (actions/setup-java)</summary> ### [`v3.12.0`](https://github.com/actions/setup-java/releases/tag/v3.12.0) [Compare Source](https://github.com/actions/setup-java/compare/v3.11.0...v3.12.0) In scope of this release the following changes were made: **Bug fixes:** - Always check postfix "Contents/Home" on macOS by [@​erwin1](https://github.com/erwin1) in [https://github.com/actions/setup-java/pull/397](https://github.com/actions/setup-java/pull/397) - Fix sbt/scala cache key by [@​Dogacel](https://github.com/Dogacel) in [https://github.com/actions/setup-java/pull/478](https://github.com/actions/setup-java/pull/478) - Corretto toolcache folder name fix by [@​IvanZosimov](https://github.com/IvanZosimov) in [https://github.com/actions/setup-java/pull/480](https://github.com/actions/setup-java/pull/480) - Update versions of Oracle JDK and Microsoft Build of OpenJDK by [@​anishi1222](https://github.com/anishi1222) in [https://github.com/actions/setup-java/pull/489](https://github.com/actions/setup-java/pull/489) - Update Oracle JDK download URL calculation by [@​nikolai-laevskii](https://github.com/nikolai-laevskii) in [https://github.com/actions/setup-java/pull/507](https://github.com/actions/setup-java/pull/507) **Feature implementations:** - Add versions properties to cache by [@​Endi327](https://github.com/Endi327) in [https://github.com/actions/setup-java/pull/280](https://github.com/actions/setup-java/pull/280) **Resolving dependencies issues:** - Remove implicit dependencies by [@​nikolai-laevskii](https://github.com/nikolai-laevskii) in [https://github.com/actions/setup-java/pull/494](https://github.com/actions/setup-java/pull/494) - Update xml2js by [@​dmitry-shibanov](https://github.com/dmitry-shibanov) in [https://github.com/actions/setup-java/pull/484](https://github.com/actions/setup-java/pull/484) - Update dependencies by [@​IvanZosimov](https://github.com/IvanZosimov) in [https://github.com/actions/setup-java/pull/511](https://github.com/actions/setup-java/pull/511) **Infrastructure updates:** - Fix glob bug in package.json scripts section by [@​IvanZosimov](https://github.com/IvanZosimov) in [https://github.com/actions/setup-java/pull/475](https://github.com/actions/setup-java/pull/475) - Update mocks by [@​nikolai-laevskii](https://github.com/nikolai-laevskii) in [https://github.com/actions/setup-java/pull/498](https://github.com/actions/setup-java/pull/498) **Documentation changes:** - Instruction to download custom distribution JDK and install by [@​ragsmpl](https://github.com/ragsmpl) in [https://github.com/actions/setup-java/pull/500](https://github.com/actions/setup-java/pull/500) #### New Contributors - [@​erwin1](https://github.com/erwin1) made their first contribution in [https://github.com/actions/setup-java/pull/397](https://github.com/actions/setup-java/pull/397) - [@​Dogacel](https://github.com/Dogacel) made their first contribution in [https://github.com/actions/setup-java/pull/478](https://github.com/actions/setup-java/pull/478) - [@​anishi1222](https://github.com/anishi1222) made their first contribution in [https://github.com/actions/setup-java/pull/489](https://github.com/actions/setup-java/pull/489) - [@​nikolai-laevskii](https://github.com/nikolai-laevskii) made their first contribution in [https://github.com/actions/setup-java/pull/498](https://github.com/actions/setup-java/pull/498) - [@​ragsmpl](https://github.com/ragsmpl) made their first contribution in [https://github.com/actions/setup-java/pull/500](https://github.com/actions/setup-java/pull/500) - [@​Endi327](https://github.com/Endi327) made their first contribution in [https://github.com/actions/setup-java/pull/280](https://github.com/actions/setup-java/pull/280) **Full Changelog**: actions/setup-java@v3...v3.12.0 </details> <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v2.21.2`](https://github.com/github/codeql-action/compare/v2.21.1...v2.21.2) [Compare Source](https://github.com/github/codeql-action/compare/v2.21.1...v2.21.2) ### [`v2.21.1`](https://github.com/github/codeql-action/compare/v2.21.0...v2.21.1) [Compare Source](https://github.com/github/codeql-action/compare/v2.21.0...v2.21.1) </details> <details> <summary>gradle/gradle-build-action (gradle/gradle-build-action)</summary> ### [`v2.7.0`](https://github.com/gradle/gradle-build-action/releases/tag/v2.7.0) [Compare Source](https://github.com/gradle/gradle-build-action/compare/v2.6.1...v2.7.0) ##### GitHub Dependency Graph support In this release, the GitHub Dependency Graph support is no longer considered "experimental", and should be considered ready for production use. You can read more about the Dependency Graph support in [the README chapter](https://github.com/gradle/gradle-build-action#github-dependency-graph-support). ##### Changes - Update to [`github-dependency-graph-gradle-plugin@v0.2.0`](https://plugins.gradle.org/plugin/org.gradle.github-dependency-graph-gradle-plugin/0.2.0) - Dependency graph uses Gradle Settings file as manifest location (if Settings file exists) - Adds a `dependency-graph-file` output to any step that generates a Dependency Graph file ##### Changelog </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/slsa-framework/slsa-github-generator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Ian Lewis <ianlewis@google.com> Co-authored-by: Ian Lewis <ianlewis@google.com>
enteraga6
referenced
this pull request
in enteraga6/slsa-github-generator
Aug 8, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | actions/setup-java | action | digest | `cd89f46` -> `b943a4e` | | [actions/setup-java](https://github.com/actions/setup-java) | action | minor | `v3.11.0` -> `v3.12.0` | | [actions/setup-java](https://github.com/actions/setup-java) | action | digest | `5ffc13f` -> `cd89f46` | | [github/codeql-action](https://github.com/github/codeql-action) | action | patch | `v2.21.0` -> `v2.21.2` | | [gradle/gradle-build-action](https://github.com/gradle/gradle-build-action) | action | minor | `v2.6.1` -> `v2.7.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/setup-java (actions/setup-java)</summary> ### [`v3.12.0`](https://github.com/actions/setup-java/releases/tag/v3.12.0) [Compare Source](https://github.com/actions/setup-java/compare/v3.11.0...v3.12.0) In scope of this release the following changes were made: **Bug fixes:** - Always check postfix "Contents/Home" on macOS by [@​erwin1](https://github.com/erwin1) in [https://github.com/actions/setup-java/pull/397](https://github.com/actions/setup-java/pull/397) - Fix sbt/scala cache key by [@​Dogacel](https://github.com/Dogacel) in [https://github.com/actions/setup-java/pull/478](https://github.com/actions/setup-java/pull/478) - Corretto toolcache folder name fix by [@​IvanZosimov](https://github.com/IvanZosimov) in [https://github.com/actions/setup-java/pull/480](https://github.com/actions/setup-java/pull/480) - Update versions of Oracle JDK and Microsoft Build of OpenJDK by [@​anishi1222](https://github.com/anishi1222) in [https://github.com/actions/setup-java/pull/489](https://github.com/actions/setup-java/pull/489) - Update Oracle JDK download URL calculation by [@​nikolai-laevskii](https://github.com/nikolai-laevskii) in [https://github.com/actions/setup-java/pull/507](https://github.com/actions/setup-java/pull/507) **Feature implementations:** - Add versions properties to cache by [@​Endi327](https://github.com/Endi327) in [https://github.com/actions/setup-java/pull/280](https://github.com/actions/setup-java/pull/280) **Resolving dependencies issues:** - Remove implicit dependencies by [@​nikolai-laevskii](https://github.com/nikolai-laevskii) in [https://github.com/actions/setup-java/pull/494](https://github.com/actions/setup-java/pull/494) - Update xml2js by [@​dmitry-shibanov](https://github.com/dmitry-shibanov) in [https://github.com/actions/setup-java/pull/484](https://github.com/actions/setup-java/pull/484) - Update dependencies by [@​IvanZosimov](https://github.com/IvanZosimov) in [https://github.com/actions/setup-java/pull/511](https://github.com/actions/setup-java/pull/511) **Infrastructure updates:** - Fix glob bug in package.json scripts section by [@​IvanZosimov](https://github.com/IvanZosimov) in [https://github.com/actions/setup-java/pull/475](https://github.com/actions/setup-java/pull/475) - Update mocks by [@​nikolai-laevskii](https://github.com/nikolai-laevskii) in [https://github.com/actions/setup-java/pull/498](https://github.com/actions/setup-java/pull/498) **Documentation changes:** - Instruction to download custom distribution JDK and install by [@​ragsmpl](https://github.com/ragsmpl) in [https://github.com/actions/setup-java/pull/500](https://github.com/actions/setup-java/pull/500) #### New Contributors - [@​erwin1](https://github.com/erwin1) made their first contribution in [https://github.com/actions/setup-java/pull/397](https://github.com/actions/setup-java/pull/397) - [@​Dogacel](https://github.com/Dogacel) made their first contribution in [https://github.com/actions/setup-java/pull/478](https://github.com/actions/setup-java/pull/478) - [@​anishi1222](https://github.com/anishi1222) made their first contribution in [https://github.com/actions/setup-java/pull/489](https://github.com/actions/setup-java/pull/489) - [@​nikolai-laevskii](https://github.com/nikolai-laevskii) made their first contribution in [https://github.com/actions/setup-java/pull/498](https://github.com/actions/setup-java/pull/498) - [@​ragsmpl](https://github.com/ragsmpl) made their first contribution in [https://github.com/actions/setup-java/pull/500](https://github.com/actions/setup-java/pull/500) - [@​Endi327](https://github.com/Endi327) made their first contribution in [https://github.com/actions/setup-java/pull/280](https://github.com/actions/setup-java/pull/280) **Full Changelog**: actions/setup-java@v3...v3.12.0 </details> <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v2.21.2`](https://github.com/github/codeql-action/compare/v2.21.1...v2.21.2) [Compare Source](https://github.com/github/codeql-action/compare/v2.21.1...v2.21.2) ### [`v2.21.1`](https://github.com/github/codeql-action/compare/v2.21.0...v2.21.1) [Compare Source](https://github.com/github/codeql-action/compare/v2.21.0...v2.21.1) </details> <details> <summary>gradle/gradle-build-action (gradle/gradle-build-action)</summary> ### [`v2.7.0`](https://github.com/gradle/gradle-build-action/releases/tag/v2.7.0) [Compare Source](https://github.com/gradle/gradle-build-action/compare/v2.6.1...v2.7.0) ##### GitHub Dependency Graph support In this release, the GitHub Dependency Graph support is no longer considered "experimental", and should be considered ready for production use. You can read more about the Dependency Graph support in [the README chapter](https://github.com/gradle/gradle-build-action#github-dependency-graph-support). ##### Changes - Update to [`github-dependency-graph-gradle-plugin@v0.2.0`](https://plugins.gradle.org/plugin/org.gradle.github-dependency-graph-gradle-plugin/0.2.0) - Dependency graph uses Gradle Settings file as manifest location (if Settings file exists) - Adds a `dependency-graph-file` output to any step that generates a Dependency Graph file ##### Changelog </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/slsa-framework/slsa-github-generator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Ian Lewis <ianlewis@google.com> Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: Noah Elzner <elzner@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As the latest JDK of Microsoft Build of OpenJDK could not be downloaded with the current
setup-javaaction,microsoft-openjdk-versions.jsonandmicrosoft-installer.test.tswere modified. Along with this modification,oracle-installer.test.tswas also changed since the latest JDK could not be also downloaded with the current action.Related issue:
As of now no related issue exists.
Check list: