Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-version seems to be missing from outputs when installing PyPy #345

Closed
2 tasks done
DanielNoord opened this issue Mar 1, 2022 · 3 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@DanielNoord
Copy link

DanielNoord commented Mar 1, 2022

Description:
Run
Workflow

In the above job the Restore Python Virtual Environment step uses the following key:

 ${{ runner.os }}-${{ steps.python.outputs.python-version }}-${{
            needs.prepare-tests-pypy.outputs.python-key }}

See L479 of the linked workflow file.

However, if you look at the key shown on L15 of that step you see that the python-version is missing.

This step does work for the cpython jobs on both Linux and Windows, but not for PyPy.
Is this a known issue?

Edit: I checked and this behaviour did not occur a couple of weeks ago. Might this be related to #342?

Action version:
3.0.0

Platform:

  • Ubuntu

Runner type:

  • Hosted

Tools version:
pypy-3.6, pypy-3.7 and possibly more.

Repro steps:
See the run and workflow linked above.

Expected behavior:
The setup-python action to have python-version in its outputs when PyPy is installed.

Actual behavior:
python-version seems to be missing.

@marko-zivic-93
Copy link
Contributor

Hello @DanielNoord
Thank you for your report!
We will take a look at this issue and come back with results as soon as possible.

@dsame
Copy link
Contributor

dsame commented Mar 31, 2022

@marko-zivic-93 please review my PR

@DanielNoord
Copy link
Author

I think this can be closed now that #365 has been merged. @brcrista Gentle ping since you merged that PR 😄

@brcrista brcrista closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants