Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cache-hit output #371

Closed
dhvcc opened this issue Apr 2, 2022 · 3 comments · Fixed by #373
Closed

Introduce cache-hit output #371

dhvcc opened this issue Apr 2, 2022 · 3 comments · Fixed by #373
Labels
feature request New feature or request to improve the current logic

Comments

@dhvcc
Copy link
Contributor

dhvcc commented Apr 2, 2022

Description:
I'd like to propose adding a new output called cache-hit (like in actions/cache) to show whether dependency cache was hit.

Justification:
Since this action utilizes caching mechanic I think it would be needed to have this meta data in output since we can't access internal steps from outside.
This would be helpful if, for example, we need add stuff to PATH if this cache was hit. Another example is when you want to do optional poetry install, because there's no lock file and poetry will first try to resolve even if deps are there.

Are you willing to submit a PR?
Yes, for sure.

@dhvcc dhvcc added feature request New feature or request to improve the current logic needs triage labels Apr 2, 2022
@dmitry-shibanov
Copy link
Contributor

Hello @dhvcc. Thank you for your proposal. I think this enhancement can be implemented. If you're willing to contribute, please feel free to prepare a pull request.

@dhvcc
Copy link
Contributor Author

dhvcc commented Apr 2, 2022

@dmitry-shibanov thanks for the reply! I will take a look at the code and try to craft something today

@dhvcc dhvcc mentioned this issue Apr 3, 2022
2 tasks
@dhvcc
Copy link
Contributor Author

dhvcc commented Apr 5, 2022

Just as an addition - perhaps this type of output may be usefull in other setup-* workflows? I've checked an saw only setup-node providing the same output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants