Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL install on Ubuntu/Windows. #636

Merged
merged 31 commits into from
Jun 2, 2020
Merged

PostgreSQL install on Ubuntu/Windows. #636

merged 31 commits into from
Jun 2, 2020

Conversation

Darleev
Copy link
Contributor

@Darleev Darleev commented Mar 27, 2020 •
edited
Loading

Description

Github Issue link.
Size: 200 Mb
Time:
Windows: 5 minutes
Ubuntu: 2 minutes

Check list

sergey-akhalkov
sergey-akhalkov reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@sergey-akhalkov sergey-akhalkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the licence is for PostgreSQL? Do I get it right that we can add it to the image without any concerns?

@Darleev
Copy link
Contributor Author

Darleev commented Apr 19, 2020

What the licence is for PostgreSQL? Do I get it right that we can add it to the image without any concerns?

PostgreSQL is open-source and free to use forever. More information about it can be found here

@veyndan veyndan mentioned this pull request May 17, 2020
Merged
@AlenaSviridenko
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@AlenaSviridenko AlenaSviridenko merged commit 3be17cf into actions:master Jun 2, 2020
@al-cheb al-cheb mentioned this pull request Jun 3, 2020
Merged
4 tasks
@kentonv kentonv mentioned this pull request Jun 21, 2020
Closed
6 tasks
@kentonv
Copy link

kentonv commented Jun 21, 2020

Hello, I think this broke MinGW because Postgres's include directory is placed on the include path by default, and it provides the file pthread.h, which is incompatible with MinGW's version of the same file. I filed #1089 regarding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-akhalkov sergey-akhalkov sergey-akhalkov approved these changes

@AlenaSviridenko AlenaSviridenko AlenaSviridenko approved these changes

@maxim-lobanov maxim-lobanov maxim-lobanov approved these changes

@miketimofeev miketimofeev miketimofeev approved these changes

@alepauly alepauly Awaiting requested review from alepauly

@al-cheb al-cheb Awaiting requested review from al-cheb

@andy-mishechkin andy-mishechkin Awaiting requested review from andy-mishechkin

@vsafonkin vsafonkin Awaiting requested review from vsafonkin

@dibir-magomedsaygitov dibir-magomedsaygitov Awaiting requested review from dibir-magomedsaygitov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Darleev @AlenaSviridenko @kentonv @sergey-akhalkov @maxim-lobanov @al-cheb @miketimofeev