Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: live processing feedback using rails 5 action cables. #170

Open
shivgarg5676 opened this issue Oct 8, 2019 · 1 comment
Open

Comments

@shivgarg5676
Copy link

Some time ago, I wrote a plugin for active admin to handle large excel uploads. The problem with the large uploads is that it blocks the main thread if we are processing things synchronously. If we process large files using some worker process, the user does not get any feedback after the processing is done.
My proposal is for the second approach.
One good way to give feedback to the user is by emailing after the processing is complete. But that is a traditional solution and the user has to migrate away from the tool.

Another good approach is to use action cables to give live feedback to the users. I have a basic implementation here.
https://github.com/shivgarg5676/active_admin_excel_upload

Can something similar to this be useful here? I would like to spend some time bringing a new functionality for this and will start writing a detailed proposal.

@workgena
Copy link
Contributor

workgena commented Oct 8, 2019

I can't speak for the other maintainers, but here is my point of view...

The idea with Action Cable is good for User Experience. I've always wanted this feature. But there are a few things you/we should be aware of:

  • Compatibility with Rails 4 should remain (without Action Cable)
  • Writing new tests for such feature is mandatory
  • The code-complexity may increase significantly
  • If there would be very complex/extensive changes then, perhaps, it would be better to make it as a separate Gem(it may depend on active_admin_import, no restrictions / MIT license)

It wouldn't be easy, if you @shivgarg5676 are ready for this challenge then go for it 🚀 🌚 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants