Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choco fix for upcoming checksum requirement #73

Closed
activescott opened this issue Sep 4, 2016 · 1 comment
Closed

choco fix for upcoming checksum requirement #73

activescott opened this issue Sep 4, 2016 · 1 comment
Milestone

Comments

@activescott
Copy link
Owner

Looks like for legacy (or ignorance) reasons lessmsi's choco package's chocolateyInstall.ps1 file is using Install-ChocolateyZipPackage. This will soon require a checksum (or maybe not since it is local?). In any case according to that doc should be using [Get-ChocolateyUnzip](https://github.com/chocolatey/choco/wiki/HelpersGetChocolateyUnzip] instead.

Asked for guidance on this at chocolatey/choco#112 (comment)

@activescott activescott added this to the vNext milestone Sep 4, 2016
@ferventcoder
Copy link
Contributor

Docs were not always as good as they are now - it's likely you just missed it. Plus LessMSI started with pulling the file from a remote source and when you took over, it's likely you converted it to a local source and it just worked. So there was no real reason to explore further changes.

The advantage of Get-ChocolateyUnzip is that it doesn't take the additional step of copying the zip somewhere else on the filesystem before extraction. So you only have one copy and less disk space used.

@activescott activescott modified the milestones: vNext, v1.5 Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants