-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.5 and up no longer work in Wine #83
Comments
I'm guessing this is due to this line which was added in this commit. Apparently some problem loading LessIO on Wine. LessIO uses a several Win32 native methods so I suspect that is at play here. Someone needs to debug though. @jethrogb Is this something you're up for investigating further? |
“aspires to be platform independent” 😃 I'm happy to provide help debugging and testing, but I don't have a Windows/.Net toolchain setup. |
... |
@mirh I think since it worked in older versions of lessmsi it is likely we've introduced something that wine supports. I don't use it on wine, so I haven't taken the time to investigate yet. If you have, please let me know what's going on and I'll be happy to support you resolving it (either in lessmsi or reporting to wine). |
I am not sure if/when I'll have time to investigate this, but lessmsi is actively being used on OS X in a project I helped with a bit, but haven't spent time with recently. I do wonder if it is possible to detect running in Wine and use the previous function.
FYI/CC: @hansen-m , @rustymyers |
Finding which functions we are talking about in the first place, then check for bug reports on wine appdb, wouldn't hurt. |
I’m on v1.6.1 and getting the same error. |
So... I am still affected by this. I don't know the actual problem yet, however it seems to fail to close the handle to the cab correctly after writing:
Which then results in a sharing violation as it should:
wine --version reports wine-3.10. I don't know who's at fault here beacuse as far as I can tell the cab gets written correctly. We'll see. |
In case anyone wants to investigate this (😉) I'd start by look at the
|
FWIW, I think the problem is this call https://github.com/activescott/lessmsi/blob/master/src/LessMsi.Core/Msi/Wixtracts.cs#L386 resulting in this handle being allocated https://github.com/activescott/libmspack4n/blob/master/libmspack4n/MSCabinet.cs#L44 but not properly closed. I have no further Idea what is going on as I most probably can't contribute code back for legal reasons and therefore have not bothered to set up a debug environment, sorry about that. I think that this is a bug in wine, but I'm seriously lacking the capabilities to bisect. If anyone with wine hacking expierience besides me is interested in bisecting, feel free to do so :) |
Latest version works just fine in wine, at least once you install dotnet45. |
With lessmsi 1.4:
(success)
With lessmsi 1.5, 1.5.1, 1.6:
(failure)
I've tried several different MSI packages, they all show the same behavior. I'm using wine 1.6.2.
The text was updated successfully, but these errors were encountered: