Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong edge costs after collapsing edges? #47

Closed
aheld84 opened this issue Sep 6, 2023 · 1 comment
Closed

Wrong edge costs after collapsing edges? #47

aheld84 opened this issue Sep 6, 2023 · 1 comment

Comments

@aheld84
Copy link
Contributor

aheld84 commented Sep 6, 2023

Dear pfaedle developers,

Could it be the case that edge costs are calculated from beeline distances (start node to end node distance) instead of the real line string length here

e->pl().setCost(costToInt(dist(e->getFrom(), e->getTo()) /
after collapsing the edges?

Or did I misunderstand the concept of the edge cost? My understanding is that the edge cost should be proportional to the travel time, so the real length should be used .

All the best
Alex

@patrickbr
Copy link
Member

patrickbr commented Sep 6, 2023

Indeed - this seems to have been introduced last year. Previously, the logic here was to first compute the costs on the uncollapsed edges, and adding them up during the subsequent collapsing.

This explains some strange results I noticed during the last months. Thanks for pointing that out!

Fixed in 5c1ad45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants