Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio not being included in bundle due to package_folder_prefix #356

Closed
dhalbert opened this issue Nov 30, 2021 · 1 comment · Fixed by #357
Closed

asyncio not being included in bundle due to package_folder_prefix #356

dhalbert opened this issue Nov 30, 2021 · 1 comment · Fixed by #357

Comments

@dhalbert
Copy link
Contributor

See adafruit/circuitpython-build-tools#82, which is the fundamental issue.

@FoamyGuy
Copy link
Contributor

Thinking about this from a different angle. Is there a specific reason that the module is named asyncio instead of adafruit_asyncio? My guess is perhaps this was done to equalize the import and as much of the API as possible between CircuitPython and CPython.

But in other libraries that are similar modeled after and contain a subset of APIs of CPython modules they do have the adafruit_ in their name, and examples use as in the import to change the name to match CPython. The one that comes to mind for me is: https://github.com/adafruit/Adafruit_CircuitPython_Requests which has the module named adafruit_requests and imports in the examples are done like this:

import adafruit_requests as requests

Maybe it would make sense to add the adafruit_ prefix to asyncio instead of making an exception for it in the bundle / build tools command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants