Proposal to improve WVariant part number define logic #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hiya the ifdef change is ok, but please remove the json file :) |
|
Alright, I finally got around to cleaning this up. I fixed the ethernet handler, and added all the -N and -P components such that they get all available TC/TCC channels. Thanks! |
ladyada
approved these changes
Aug 1, 2022
|
done thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this hacky fix to build with the SAME54N20A. Is there a way to use the CMSIS definitions to automatically build the correct list of _ETCChannel enum options? I will try to explore soon. I've managed to get everything building with forks of all the adafruit repos, but I'd rather not have to maintain that complexity if I can help the upstream support a wider range of parts.