Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Tests not discovered with Expecto >= 4.x.x #11

Closed
fbehrens opened this issue Mar 9, 2017 · 12 comments
Closed

Tests not discovered with Expecto >= 4.x.x #11

fbehrens opened this issue Mar 9, 2017 · 12 comments

Comments

@fbehrens
Copy link

fbehrens commented Mar 9, 2017

Hi,

I addedd it through nuget Expecto.VisualStudio.TestAdapter version_in_path: true
paket install,
This installs Expecto.VisualStudio.TestAdapter (1.0.0-alpha005) - version_in_path: true

and then restart Visual Studio.

Microsoft Visual Studio Enterprise 2015
Version 14.0.25431.01 Update 3
Microsoft .NET Framework
Version 4.6.01055

I can open Test-Explorer bun none of my Expecto tests are discovered.
It's not that I really wonder about something in Visual Studio is not working,
but it would be nice if it would.

@nikolamilekic
Copy link
Contributor

@fbehrens Try with an older version of Expecto (3.2). Also, alpha005 does not support FsCheck (issue #9) and async tests (issue #4).

@adamchester
Copy link
Owner

Released 1.0.0-alpha006 however I expect this issue still exists.

@fbehrens
Copy link
Author

I tried with

Main Expecto - 3.2.1
Main Expecto.VisualStudio.TestAdapter - 1.0.0-alpha006

ropenend solution, rebuild solution, but no test in test-Explorer apperar.
With expecto 3.2.0 i got the same result.

Here is my example code https://github.com/fbehrens/Fsharp-playground

@nikolamilekic
Copy link
Contributor

@fbehrens You need to add Expecto.VisualStudio.TestAdapter to your project's paket.references (followed by .paket/paket.exe install). I just tried that with your code and it worked.

@fbehrens
Copy link
Author

@nikolamilekic Thanks for support :). It discoverd the test in with Expecto 3.2.1 after i did.
@adamchester Thanks for the update, I can confirm your expectations.

@fbehrens
Copy link
Author

I don't know if you will also support VS2017. Will You ?
Right now tests are not discovered in VS2017.

Main Expecto - 3.2.1
Main Expecto.VisualStudio.TestAdapter - 1.0.0-alpha006

Microsoft Visual Studio Enterprise 2017
Version 15.0.26228.4 D15RTWSVC
Microsoft .NET Framework
Version 4.6.01586

@nikolamilekic
Copy link
Contributor

@fbehrens That's strange because I tried your project with 2017 and it worked after I made the paket.references change.

@fbehrens
Copy link
Author

@nikolamilekic Yes, indeed. I have no idea why.
Its a fresh install of VS2017. Just cloned, paket restore, and rebuild all.

@adamchester adamchester changed the title Tests are not discovered in Test explorer Tests not discovered with Expecto >= 4.x.x Mar 11, 2017
@adamchester
Copy link
Owner

Hey @fbehrens, your solution currently works here in 2017 too, no changes required.
image

I also tried upgrading expecto to 4.0.3 and it fails still, so I am leaving this open:
image

@adamchester
Copy link
Owner

Alright, the solution here might as simple as recompiling this test adapter against expecto 4.x, fixing a few minor breaking changes, then publishing again.

image

@adamchester
Copy link
Owner

@fbehrens
Copy link
Author

@nikolamilekic Thanks for checking with VS2017. I pulled from the wrong remote and missed again the entry in the paket.references 🤦

@adamchester thanks for the fixes and update to 4.0.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants