Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mochawesome module size 1.5.5 -> 2.0.x #133

Closed
tiagomestre opened this issue Feb 17, 2017 · 2 comments
Closed

mochawesome module size 1.5.5 -> 2.0.x #133

tiagomestre opened this issue Feb 17, 2017 · 2 comments

Comments

@tiagomestre
Copy link

At this moment, in my opinion, the new versions of mochawesome (2.0.x) create too much impact in continuous integration where each build is from a clean slate.

Version size comparison: v1.5.5 -> v2.0.3 (not including dev dependencies)

Size: ~12mb -> ~116mb
Files: 1667 -> 95635
Folders: 174 -> 8418

The cause of this massive change was the inclusion of the material-design-icons module (mochawesome-report-generator dependency).

material-design-icons:

Size: ~82mb
Files: 89 814
Folders: 8 002

Even though I'm still going to use version 1.5.5 to generate the html report, I think the size of the module is something to take in consideration.

Possible solutions:

  • Revert to the old icons/resources
  • Include only the necessary resources from material-design-icons directly inside the mochawesome-report-generator dependency module.
@adamgruber
Copy link
Owner

@tiagomestre Good find. The problem wasn't the addition of material-design-icons itself but the fact that it was listed as a dependency instead of a devDependency. I have released mochawesome 2.0.4 which points to version 1.1.0 of mochawesome-report-generator which no longer contains packages that were only needed during development. It should greatly reduce the overall package size. Please upgrade and let me know how it goes.

@tiagomestre
Copy link
Author

Much better now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants