Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: remove legacy nav btn float (fixes #93) #94

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Update: remove legacy nav btn float (fixes #93) #94

merged 1 commit into from
Mar 19, 2024

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Mar 13, 2024 •
edited
Loading

Fixes #93

Update

The nav button float style is no longer required since the plugin was updated to support data-order.

Core also overrides any .nav__btn float styles.

@kirsty-hames kirsty-hames self-assigned this Mar 13, 2024
joe-allen-89
joe-allen-89 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

swashbuck
swashbuck approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 828ea5a into master Mar 19, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/93 branch March 19, 2024 09:14
github-actions bot pushed a commit that referenced this pull request Mar 19, 2024
@semantic-release-bot
Chore(release): 5.5.0 [skip ci]
208d697 
# [5.5.0](v5.4.0...v5.5.0) (2024-03-19)

### Update

* Remove legacy nav btn float (#94) ([828ea5a](828ea5a)), closes [#94](#94)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove legacy nav btn float
5 participants
@kirsty-hames @swashbuck @cahirodoherty-learningpool @joe-allen-89 @oliverfoster