Spine todo app rewrite #127
Conversation
|
I just went through this and it looks good to merge. Would you like me to ask Alex MacCaw for a quick code review or are you pretty happy there are no further improvements we can probably make to it? |
|
I'm pretty happy with it. Though it's the first time I use CoffeScript or Spine, so I might be doing something stupid. There are a couple of TODOs in there, which I just couldn't figure out. One of them looks like a Spine bug. I would love a code review if he's interested in doing it 😃 |
…rewrite * 'master' of github.com:addyosmani/todomvc: Delicious new template
|
|
||
| render: => | ||
| @replace TPL( @todo ) | ||
| @ |
There was a problem hiding this comment.
I know this is perfectly valid coffee code, but it isn't that readable IMHO. What about a simple "this" ?
There was a problem hiding this comment.
I don't see how using this is anymore readable. @ is used in the rest of the code, and I want to be consistent.
There was a problem hiding this comment.
I'm only talking when it's alone. It doesn't feel clear to me, that's all.
With routing. Fixes #70.
Depends on pull #126.