Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar integration / plugin #276

Open
maximAtanasov opened this issue Aug 6, 2019 · 3 comments
Open

Sonar integration / plugin #276

maximAtanasov opened this issue Aug 6, 2019 · 3 comments

Comments

@maximAtanasov
Copy link
Member

We should consider integrating the SonarJava static code analyzer in Coderadar.
The source code can be found here: https://github.com/SonarSource/sonar-java
SonarJava is used in SonarLint and SonarQube.

A full list of the analyzers Sonar offers can be found here:
https://www.sonarsource.com/products/codeanalyzers/

Most of them are open source and LGPL licensed, which as far as I know, should be compatible with the MIT license.

@jo2
Copy link
Collaborator

jo2 commented Aug 6, 2019

The LGPL is way more restricting than the MIT license. If we use code under the LGPL coderadar has to be under the LGPL, too. An exception to that is if coderadar is completly independent from the code under the LGPL. I think because we're using it in a plugin, the plugin has to be published under the LGPL but it shouldn't affect coderadar as a project.

@maximAtanasov
Copy link
Member Author

An exception to that is if coderadar is completly independent from the code under the LGPL.

I think you're confusing the LGPL with GPL. LGPL does not force you to switch licenses. The only requirement is that you publish any changes you've made to the library code.

Extract from LGPL:

A program that contains no derivative of any portion of the Library, but is designed to work with the Library by being compiled or linked with it, is called a "work that uses the Library". Such a work, in isolation, is not a derivative work of the Library, and therefore falls outside the scope of this License.

Presumably, we will not modify the libraries, but rather use them directly in our own plugins.

@jo2
Copy link
Collaborator

jo2 commented Aug 6, 2019

If we're using the libraries instead of a fork that'll work but if we want to deliver or ndistribute a compiled version the compiled version falls inside the LGPL:

However, linking a "work that uses the Library" with the Library creates an executable that is a derivative of the Library (because it contains portions of the Library), rather than a "work that uses the library". The executable is therefore covered by this License.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants