Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Switch: spacing when there is no text #568

Closed
robergro opened this issue Oct 24, 2023 · 3 comments · Fixed by #551
Closed

[Fix] Switch: spacing when there is no text #568

robergro opened this issue Oct 24, 2023 · 3 comments · Fixed by #551
Assignees
@robergro
Labels
Bug A bug to fix
Milestone
2023 Q4 - Sprint 2

Comments

@robergro
Copy link
Contributor

robergro commented Oct 24, 2023 •
edited
Loading

On SwiftUI, if we remove the text (set text to nil), the space between the toggle and the text is still here BUT it shouldn't !
@robergro robergro self-assigned this Oct 24, 2023
@robergro robergro added the Bug A bug to fix label Oct 24, 2023
@robergro robergro added this to the Q4 - Sprint 2 milestone Oct 24, 2023
@robergro robergro linked a pull request Oct 24, 2023 that will close this issue
[Fix] Switch: Remove the space when there is no text #551
Merged
@elisa-hery
Copy link

elisa-hery commented Oct 26, 2023 •
edited
Loading

@robergro : Bugfix tested, I just noticed 1 thing : when you switch from right to left alignement behaviour is weird (see video below). Is it related to demo app or sthg could be improved ?

Enregistrement.de.l.ecran.2023-10-25.a.15.32.25.mov

@elisa-hery
Copy link

elisa-hery commented Oct 27, 2023 •
edited
Loading

new ticket for the alignement problem --> #584

@elisa-hery
Copy link

I'm moving this one to done @robergro !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robergro robergro

Labels
Bug A bug to fix
Projects
None yet
Milestone
2023 Q4 - Sprint 2
Development

Successfully merging a pull request may close this issue.

[Fix] Switch: Remove the space when there is no text adevinta/spark-ios
2 participants
@robergro @elisa-hery