Add management and performance URL schemes #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed icarErrorResource to icarBatchResultMessage, and added icarBatchResultSeverityType enum.
Batch POSTS now always return an array of icarBatchResult, each of which may contain an array of icarErrorWarningMessageResource. Single POSTs if successful return the posted object (ID filled in), otherwise they return an errors array of icarErrorWarningMessageResource. Sorry for renaming the file, but it helped to clarify its purpose.
Renamed icarErrorWarningMessage Resource to icarResponseMessageResource based on feedback to PR adewg#232
Added URL schemes for management (animal sets, animal set join/leave, and devices), and performance (weights, conformation scores, breeding values). Along with other commits, resolves adewg#154.
cookeac
requested review from
ahokkonen,
alamers and
AndreasSchultzGEA
and removed request for
AndreasSchultzGEA
ahokkonen
reviewed
Aug 18, 2021
| } | ||
| } | ||
| }, | ||
| "/batches/{location-scheme}/{location-id}/diagnoses": { |
There was a problem hiding this comment.
Should "locations" path be added after /batches -> "/batches/locations/{location-scheme}/{location-id}/diagnoses"? This question also applies to all the other "batches" endpoints.
url-schemes/managementURLScheme.json
Outdated
| } | ||
| } | ||
| }, | ||
| "/batches/{location-scheme}/{location-id}/animal-sets": { |
There was a problem hiding this comment.
Should "locations" path be added after /batches -> "/batches/locations/{location-scheme}/{location-id}/diagnoses"? This question also applies to all the other "batches" endpoints in managementURLScheme.json.
| } | ||
| } | ||
| }, | ||
| "/batches/{location-scheme}/{location-id}/weights": { |
There was a problem hiding this comment.
Should "locations" path be added after /batches -> "/batches/locations/{location-scheme}/{location-id}/diagnoses"? This question also applies to all the other "batches" endpoints in performanceURLScheme.json.
Based on comments in the PR.
erwinspeybroeck
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added URL schemes for management (animal sets, animal set join/leave, and devices), and performance (weights, conformation scores, breeding values).
Along with other PRs, resolves #154.