Changes for parturition event with new progeny details #243
Conversation
|
@erwinspeybroeck as far as I remember we agreed on leaving the original array, but marking it as 'deprecated'. And we can then remove it completely in 2.x |
|
Hi, what about the birthWeigtScore? |
|
This is in progress. We discussed at the last meeting how these "scores" could be handled as enumerations, but I also remind you that you can always extend the schema for days that only your country or application uses.
…________________________________
From: Ditlev Rosendahl Baun ***@***.***>
Sent: Friday, August 27, 2021 10:50:56 PM
To: adewg/ICAR ***@***.***>
Cc: Andrew Cooke ***@***.***>; Review requested ***@***.***>
Subject: Re: [adewg/ICAR] Changes for parturition event with new progeny details (#243)
Hi, what about the birthWeigtScore?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#243 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKZG77MKNSRHS2LE3QHHACTT65UZBANCNFSM5CXMOVJQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
New field is added for "birthSize" using enumeration for common codes. @cookeac I'm still a bit unsure we we want to use Resource based type for icarParturitionProgenyDetailsType, any reason for having it like that? |
- added managementTag and name
|
One thing in addition - should also sire information be added for the progeny details or for the parturition event? |
|
looking from our perspective I would say no sire information to be added there. We always derive the sire based on reproduction events |
|
The same from our perspective |
- renames some birth status parameters - added optional tagging date
|
Added a few changes - I guess having "DiedBeforeTaggingDate" instead of a "DiedBeforeOfficialRegistrationDate" is a more correct term. What you think @erwinspeybroeck @dirbSEGES @cookeac |
|
Ok, from our side. |
|
As long as the definition of what is meant is right - in fact it means the time the farmer has to officially tag the animals, I guess |
|
PR opened for the official review |
Resolves #191
Added new types for progeny details and enumeration parameters for progeny birth statuses.
Note! This is a draft PR - work is still in progress and will be progressed after first reviews/comments.