100s of form themes assets leftover in ui.tests

[godanny86]

Expected Behaviour

Generating a general or CIF enabled project should not include forms assets in ui.tests module.

Actual Behaviour

100s of forms assets under ui.tests are leftover in a freshly generated project. Unclear if there are other features that shouldn't exist...

Reproduce Scenario (including but not limited to)

1. Generate a new project using instructions from the readme:

   $ mvn -B org.apache.maven.plugins:maven-archetype-plugin:3.2.1:generate \
   -D archetypeGroupId=com.adobe.aem \
   -D archetypeArtifactId=aem-project-archetype \
   -D archetypeVersion=35\
   -D appTitle="My Site" \
   -D appId="mysite" \
   -D groupId="com.mysite"
   

2. Observe a warning in logs generated by project:

   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/firefox/Address Submit 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/firefox/Address 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/firefox/Basic info 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Documents 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Confirmation 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Employment 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Confirmation Submit 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Employment Submit 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Expenditure 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Communication 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Basic info Submit 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Address Submit 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Address 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/assets/form/themes/ultramarine/windows/chrome/Basic info 1366x768-base.png
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/.eslintrc.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/package.json
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/README.md
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/wdio.conf.cloud.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/rules/template-rules.json
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/commons.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/wdio-pixelmatch-service/fileutils.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/wdio-pixelmatch-service/Readme.md
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/wdio-pixelmatch-service/launcher.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/wdio-pixelmatch-service/pathutils.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/wdio-pixelmatch-service/comparisonstrategy.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/config.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/util/forms.selectors.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/lib/wdio.commands.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/wdio.conf.commons.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/specs/aem/assets.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/specs/aem/basic.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/specs/aem/sites.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/specs/aem/forms.js
   [WARNING] CP Don't override file /Users/dgordon/Desktop/mysite/mysite/ui.tests/test-module/specs/aem/login.js
   [INFO] Parent element not overwritten in /Users/dgordon/Desktop/mysite/mysite/ui.apps.structure/pom.xml
   [INFO] Executing META-INF/archetype-post-generate.groovy post-generation script
   WARNING: An illegal reflective access operation has occurred
   WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/Users/dgordon/.m2/repository/org/codehaus/groovy/groovy-all/2.4.16/groovy-all-2.4.16.jar) to method java.lang.Object.finalize()
   WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
   WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
   WARNING: All illegal access operations will be denied in a future release
   

3. Observe many assets under ui.tests/test-module/assets/form/themes/ leftover in the project that are unused.

Platform and Version

Mac OS

$ java -version
java version "11.0.12" 2021-07-20 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.12+8-LTS-237)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.12+8-LTS-237, mixed mode)

$ mvn --version
Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f)
Maven home: /Applications/Utilities/Apache/apache-maven-3.8.2
Java version: 11.0.12, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-11.0.12.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac"