Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CodeMirror update #12937

Closed
zaggino opened this issue Nov 23, 2016 · 5 comments
Closed

CodeMirror update #12937

zaggino opened this issue Nov 23, 2016 · 5 comments
Labels
codemirror tracking
Milestone
Release 1.9

Comments

@zaggino
Copy link
Contributor

zaggino commented Nov 23, 2016

@adobe/brackets-committers

Latest master of CodeMirror doesn't contain built codemirror.js in the lib directory: https://github.com/codemirror/CodeMirror/tree/master/lib

Since we'll definitely want to upgrade for next version there are two options:

a) add a task to our grunt scripts that'll build codemirror.js by calling npm run build in the CodeMirror submodule
b) use CodeMirror as npm dependency

Let me know which solution you prefer.
@zaggino zaggino added this to the Release 1.9 milestone Nov 23, 2016
@petetnt
Copy link
Collaborator

petetnt commented Nov 23, 2016

Voting for b)

@swmitra
Copy link
Collaborator

swmitra commented Nov 23, 2016 •
edited
Loading

My vote for 'b'.
Off topic - We should do the same even for 'tern'. I will work on the PR where we are moving the entire JS analysis to node.

@zaggino
Copy link
Contributor Author

zaggino commented Nov 23, 2016

@petetnt @swmitra
Please also have a look at related #12933
confirmed to work in #12898 (comment)

@zaggino zaggino mentioned this issue Nov 23, 2016
Closed
@zaggino
Copy link
Contributor Author

zaggino commented Nov 23, 2016

PR here #12940

@ficristo
Copy link
Collaborator

Done in #12972
@swmitra Acorn and Tern are already installed from npm, see #11569
It would be nice to also look at #12744

This was referenced Aug 30, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
codemirror tracking
Projects
None yet
Milestone
Release 1.9
Development

No branches or pull requests
4 participants
@zaggino @petetnt @ficristo @swmitra