Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Investigate why CM event timing fix didn't fix #2806 #2824

Closed
njx opened this issue Feb 8, 2013 · 2 comments
Closed

Investigate why CM event timing fix didn't fix #2806 #2824

njx opened this issue Feb 8, 2013 · 2 comments

Comments

@njx
Copy link

njx commented Feb 8, 2013

#2806 was fundamentally due to an event timing issue, where CM wasn't sending out the redraw event for inline editors at the right time (it was sending it before the widget was actually fully re-added to the DOM). That issue was addressed upstream in codemirror/codemirror5@1c8a36e, but that CM fix didn't seem to actually fix our problem. We should try to figure out why, and more generally test whether there are other ramifications of the event timing changes in that commit.

@ghost ghost assigned njx Feb 8, 2013
@njx
Copy link
Author

njx commented Feb 9, 2013

Reviewed.

@njx
Copy link
Author

njx commented Jul 12, 2014

This bug is pretty old and it's not clear that doing this investigation at this point would be helpful. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant