You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
The current Dialogs API is a little odd; after opening the dialog, you have to manually find the dialog DOM node by using $(".dlg-class-name.instance"), and to close the dialog manually, you have to call cancelModalDialogIfOpen("dlg-class-name"). It would be cleaner if showModalDialogUsingTemplate() returned an actual dialog object, and if that had elt() and close() methods or some such.
Also, buttons on the right-hand side have to be specified in the opposite order that you want them to appear in (right-to-left instead of left-to-right), probably because they're both floated. We should probably put them in a floated container.
The text was updated successfully, but these errors were encountered:
Should the returned object be a normal javascript object, or it would be better to make a new class with the methods mentioned and create a new instance for each dialog that is then returned?
The current Dialogs API is a little odd; after opening the dialog, you have to manually find the dialog DOM node by using
$(".dlg-class-name.instance")
, and to close the dialog manually, you have to callcancelModalDialogIfOpen("dlg-class-name")
. It would be cleaner ifshowModalDialogUsingTemplate()
returned an actual dialog object, and if that hadelt()
andclose()
methods or some such.Also, buttons on the right-hand side have to be specified in the opposite order that you want them to appear in (right-to-left instead of left-to-right), probably because they're both floated. We should probably put them in a floated container.
The text was updated successfully, but these errors were encountered: