Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

make jump to definition response faster (on large JS file) #4066

Open
jodyzhang opened this issue Jun 3, 2013 · 3 comments
Open

make jump to definition response faster (on large JS file) #4066

jodyzhang opened this issue Jun 3, 2013 · 3 comments

Comments

@jodyzhang
Copy link
Contributor

I tried jump to definition for ember.js(copy/paste from https://raw.github.com/tastejs/todomvc/gh-pages/architecture-examples/emberjs/bower_components/ember/ember.js) on Ember.runLoadHooks()(line 21466):
Ember.runLoadHooks('Ember.Handlebars', Ember.Handlebars);

it takes about more than 6 seconds to find the definition on my mac(first time takes longer). code hint returns quickly, so I think we should response "jump to definition" a little fast.

@ghost ghost assigned eztierney Jun 7, 2013
@njx
Copy link
Contributor

njx commented Jun 7, 2013

Reviewed. To @eztierney to think about what to do here. I'm thinking the right eventual solution is to provide pre-cached code hint info for popular frameworks, so we don't have to actually scan the real framework file. I think we'll be setting up a meeting next week to talk about this and other possibilities for code hints.

@petetronic
Copy link
Contributor

If we had a defs file, Tern based operations will be faster. It is not intended to support speedy code intelligence on enormous files. A question though is how to deal with framework versioning. We could possibly try condensing large frameworks on-the-fly to a defs file, but Ember.js alone takes 15 seconds to condense.

@redmunds
Copy link
Contributor

Was assigned to tern team, so marking "Needs Review".

@dangoor dangoor self-assigned this Apr 1, 2014
@dangoor dangoor changed the title [js code hints]make jump to definition response faster. make jump to definition response faster (on large JS file) Apr 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants