Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Live HTML highlighting is often in the wrong place with Reveal.js #5192

Open
dangoor opened this issue Sep 13, 2013 · 10 comments
Open

Live HTML highlighting is often in the wrong place with Reveal.js #5192

dangoor opened this issue Sep 13, 2013 · 10 comments

Comments

@dangoor
Copy link
Contributor

dangoor commented Sep 13, 2013

If you're working on a Reveal.js presentation, the live highlight is often in the wrong place (even when the cursor is in an element that is visible on the screen). It may be the case that there's no easy solution to this because of the way that Reveal.js does its layout, but I thought I'd open this for comment from the people who know the live highlighting better than I do.

@ghost ghost assigned njx Sep 16, 2013
@njx
Copy link
Contributor

njx commented Sep 16, 2013

Reviewed. Medium priority to me to see if this is a more general problem.

@njx njx assigned dangoor and unassigned njx Jul 12, 2014
@njx
Copy link
Contributor

njx commented Jul 12, 2014

To @dangoor

@dangoor dangoor removed their assignment Jul 28, 2014
@redmunds
Copy link
Contributor

This may be fixed by #8922 by @marcelgerber. I tested a reveal presentation that I made for Sprint 30 Review -- it renders correctly in this branch, but also in master.

@dangoor Do you have the original reveal presentation that you can test against that PR?

@redmunds
Copy link
Contributor

FBNC back to @dangoor .

@dangoor
Copy link
Contributor Author

dangoor commented Oct 22, 2014

I just took a look at this. It is not fixed on current master (103e67d). I think this is likely a problem with the way Reveal does positioning rather than a more general problem, so I'm reducing this to low priority.

@marcelgerber
Copy link
Contributor

@dangoor Could you upload a little Reveal presentation for me to take a look at that issue?

@redmunds
Copy link
Contributor

@dangoor Note that highlighting of elements only on the current "page" of a Reveal presentation are expected to be correct. If that's the case, can you post the presentation for us to look at?

@dangoor
Copy link
Contributor Author

dangoor commented Oct 22, 2014

I've uploaded the presentation. Just start live preview on index.html there.

@redmunds
Copy link
Contributor

I didn't exhaustively test every page and element, but this looks to me. Can you provide a recipe for which page you are viewing in browser and which elements you are selecting in Brackets that have highlights out of place?

@marcelgerber
Copy link
Contributor

I see the issue.
For the best effect, it's probably best to find some way to simplify jQuery's position as much as we can and use it there. That's basically what I did, but I oversimplified it (on purpose, I didn't want 100 lines hanging around).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants