Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

One DocumentCommandHandlers integration test is failing. #7632

Open
RaymondLim opened this issue Apr 24, 2014 · 9 comments
Open

One DocumentCommandHandlers integration test is failing. #7632

RaymondLim opened this issue Apr 24, 2014 · 9 comments

Comments

@RaymondLim
Copy link
Contributor

  1. Select Integration tab in Jasmine window.
  2. Run DocumentCommandHandlers.

Result: You may get one test failure. If not, open Developer toots from Jasmine window and set a breakpoint on line 255. You may see the failure in that test. If not, then cleanup your Brackets cache and start over. Once you get it failing, you can see it failing again when you run DocumentCommandHandlers.

should swap out untitled document from working set even when not current
Error: Expected -1 to be greater than -1.
    at new jasmine.ExpectationResult (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBeGreaterThan (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/rlim/brackets/test/spec/DocumentCommandHandlers-test.js:268:75)
    at jasmine.Block.execute (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.WaitsForBlock.execute (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:2322:5)
    at file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:2336:12
@njx njx changed the title One DocumentComandHandlers integration test is failing. One DocumentCommandHandlers integration test is failing. Apr 28, 2014
@njx
Copy link
Contributor

njx commented Apr 28, 2014

Reviewed. High pri to @JeffryBooher to investigate or turn the test off if it's hard to fix.

@JeffryBooher
Copy link
Contributor

@RaymondLim I'm unable to reproduce this on Windows 8.1
I tried putting a BP on line 255 of DocumentCommandHandlers-test.js
I tried clearing my cef_data folder
Can you still repro with Master?

@njx njx added this to the Release #39 milestone May 2, 2014
@njx
Copy link
Contributor

njx commented May 2, 2014

Marking Release 39 to investigate. If we can't repro this on dev machines and can't repro it by manually trying the steps, then let's comment out the test for now.

@peterflynn
Copy link
Member

I can repro locally, so I'll see if I can find anything out...

@peterflynn
Copy link
Member

Actually, now it's not reproducing anymore. Seems to be extremely timing sensitive... will keep trying.

@JeffryBooher
Copy link
Contributor

Steps:

  1. Create an untitled document and make some changes (don't save)
  2. open another document
  3. save all
    => force to name untitled document
    Untitled document is not renamed in working set

@pthiess
Copy link
Contributor

pthiess commented May 5, 2014

@JeffryBooher Failure seems intermittent and was reproduced with Release 38 -- moving this to release 40 (milestone). Reducing priority to medium as @peterflynn suggested.

@JeffryBooher
Copy link
Contributor

Comment out test and lower to med pri

@pthiess pthiess modified the milestones: Release #39, Release #40 May 5, 2014
@pthiess pthiess modified the milestones: Release #40, Release #41 May 20, 2014
@pthiess pthiess assigned ingorichter and unassigned JeffryBooher May 20, 2014
@pthiess
Copy link
Contributor

pthiess commented May 20, 2014

@ingorichter while @JeffryBooher cannot reproduce

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants