Project Manager Revamp

[pthiess]

Project Manager is a bit tangled and fragile and my intention is to finish my React-based, test-driven revamp.

Tasks

• Update to latest React
• Merge with master
• Finish flux implementation
• Rebase on split view work
• Cleanup/commenting
• Fix the triangle/visuals
• Design extension API to support file icons and brackets-git
• Unit tests (TDD should be possible)
• Verify that recent changes to ProjectManager are accounted for
• Verify/fix bugs below (the ones that easily shake out from this work)
• Documentation for new API
• Update third party code notices

Possibly Fixes

• Drag selecting content with active Sidebar file #8578
• Brackets crashes when clicking on a large file on the sidebar #8300
• ProjectManager.renameItemInline() should return a promise #8176
• ProjectManager.createNewItem() doesn't work with rename on Linux #8175
• Can't create new folder in the place you would expect (under the root directory in one case) #7561
• File in editor not selected in project tree if folder expanded after file already open #3404
• Exception in project tree code when renaming nested file #7113
• Error when adding files to empty project #7092
• Clicking an Image file in the project tree calls FileOpen command twice #6001
• Right-clicking on a file in the project sidebar should not open it #4690
• [Core]: "&" changes to "&" when renaming a file or folder contains "&" #3648
• Project Panel loses selection in this case... #2903
• CreateNewItem() misdirecting arguments #1385
• Can't get the context menu of a binary file #7676
• Tree context menu behaves unpredictably while naming new file #4693
• Can't create two new files in a row on collapsed subfolder using context menu #4343

Still desirable to fix

These issues were not completed in time but would still be nice to fix.

• File Extension Detection (Filenames with dots) #8042
• ProjectManager.getAllFiles() doesn't usually honor includeWorkingSet=false (the supposed default) #8930

Not planning to fix

• Renaming a file inline should scroll to the middle of the page #7703 - the fix here is independent of the work being done for this feature

[dangoor]

I have verified all of the bugs. There are 4 that remain that I intend to fix because they're low hanging fruit while this code is fresh in my mind.

[dangoor]

For documentation for this, I added a note to the how to write extensions wiki page with a link to the API docs (which will be regenerated as part of the 0.44 release process). I don't think we needed any additional documentation beyond that because not many extensions try to augment the file tree.

[dangoor]

I have filed issues with all of the extensions I could find that appeared to be manipulating the file tree DOM.

[RaymondLim]

I verified that #4693 and #4343 are fixed.