Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[promises-upgrade] Find in Files reports and uses wrong scope #8812

Closed
redmunds opened this issue Aug 20, 2014 · 3 comments
Closed

[promises-upgrade] Find in Files reports and uses wrong scope #8812

redmunds opened this issue Aug 20, 2014 · 3 comments

Comments

@redmunds
Copy link
Contributor

I thought I was going crazy, but I finally found a recipe:

  1. Open Brackets with project set to "brackets" code base
  2. Double-click on utils/Async.js so it's open and in Working Set
  3. Select text "promisify"
  4. Close and restart Brackets
  5. Verify Async.js is in Working Set, open in editor, and "promisify" is selected
  6. Find > Find in Files
  7. Verify Find text field is populated with "promisify" and scope says "in project"
  8. Hit enter to execute search

Results
"4 matches in 1 file"

Expected
Entire project is searched, not just 1 file! Major code trust issue.

It only seems to happen in first search -- execute again and you'll see "25 matches in 4 files"

@redmunds
Copy link
Contributor Author

Marking High Priority. This does not reproduce in 0.42 so it seems to be a recent injection. Only happens in promises-upgrade branch.

@redmunds redmunds added this to the Release 0.43 milestone Aug 20, 2014
@redmunds
Copy link
Contributor Author

I just realized that I was in promises-upgrade branch -- this does not happen in master

@redmunds redmunds removed this from the Release 0.43 milestone Aug 20, 2014
@redmunds redmunds changed the title Find in Files reports and uses wrong scope [promises-upgrade] Find in Files reports and uses wrong scope Aug 20, 2014
@dangoor dangoor added this to the Brackets 1.0 (#0.44) milestone Aug 25, 2014
@redmunds redmunds removed this from the Release 0.44 milestone Sep 12, 2014
@redmunds
Copy link
Contributor Author

Only happens in my branch. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants