fix(markdown): catch error when using title as a property name

adobe · Jan 14, 2020 · b4b8855 · b4b8855
1 parent 2878221
commit b4b8855
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/markdownBuilder.js b/lib/markdownBuilder.js
@@ -414,7 +414,7 @@ function build({
     })();
 
     const typelink = (() => {
-      if (definition[keyword`title`]) {
+      if (definition[keyword`title`] && typeof definition[keyword`title`] === 'string') {
         // if the type has a title, always create a link to the schema
         return [text(' ('), link(`${definition[s.slug]}.md`, '', text(definition[keyword`title`])), text(')')];
       } else if (!singletype || firsttype === keyword`object` || merged) {

diff --git a/test/markdownBuilder.test.js b/test/markdownBuilder.test.js
@@ -75,6 +75,11 @@ describe('Testing Markdown Builder: title', () => {
     assertMarkdown(results.meta)
       .fuzzy`defined in: [Meta](meta-definitions-meta-properties-title.md "https&#x3A;//ns.adobe.com/helix/pipeline/meta#/definitions/meta/properties/title")`;
   });
+
+  it('Title Schema looks OK', () => {
+    assertMarkdown(results['meta-definitions-meta-properties'])
+      .fuzzy`properties Type`;
+  });
 });
 
 describe('Testing Markdown Builder: enums', () => {