Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for semantic colors to icons #1159

Closed
devongovett opened this issue Oct 13, 2020 · 0 comments · Fixed by #1182
Closed

Add support for semantic colors to icons #1159

devongovett opened this issue Oct 13, 2020 · 0 comments · Fixed by #1182
Assignees
@LFDanLu
Labels
enhancement New feature or request

Comments

@devongovett
Copy link
Member

🙋 Feature Request

The icon components should allow setting a color to one of the pre-defined spectrum semantic icon colors. Currently they can only be gray.

💁 Possible Solution

  1. Add the icon semantic color variables to the script to extract vars to ts here: https://github.com/adobe/react-spectrum/blob/main/lib/varsToTypeScript.js.
  2. Use this new IconColorValue type in the icon component.
  3. Generate the variable name based on this similar to https://github.com/adobe/react-spectrum/blob/main/packages/@react-spectrum/utils/src/styleProps.ts

🧢 Your Company/Team

RSP
@devongovett devongovett added the enhancement New feature or request label Oct 13, 2020
@LFDanLu LFDanLu self-assigned this Oct 19, 2020
@LFDanLu LFDanLu mentioned this issue Oct 20, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LFDanLu LFDanLu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding support for semantic color for icons adobe/react-spectrum
2 participants
@devongovett @LFDanLu