-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Preact support #781
Comments
Added this into a fresh |
Which components did you try? Last I tried, I had issues with Picker and some of the other collections components because of differences in the way Preact handles "key". Also I think I'd expect some differences due to the synthetic event system, eg focus bubbling in React but not in the DOM. |
Sorry I never replied here, completely lost track of it. When I ended up trying a picker component I got some errors like you said. Definitely looking forward to this issue getting worked on though! |
@mischnic has been working on it. I believe we ran into a few bugs that he's reported so waiting on resolution of those at the moment. But getting closer! 😊 |
Here's a list of issues we ran into if anyone is interested in helping here. Some have been filed with the Preact team, and some may require workarounds on our side. https://gist.github.com/mischnic/15d81e667cda5c6fa7ab60d0bc77d34b |
Closing as stale. This is not work that the team is able to take on in the near future. |
🙋 Feature Request
It would be nice to support Preact in addition to React. Preact supports most of the features we need, and is considerably more lightweight, so it would be nice to support it for applications that need to be super slim. Things should mostly already work I think, but there may be places where we rely on React specific features like the synthetic event system. We should try to abstract that.
💁 Possible Solution
useState
/useEffect
/etc. from? That might allow even more implementations that support the hooks API in the future (e.g. Haunted). How do other libraries handle this?🧢 Your Company/Team
RSP
The text was updated successfully, but these errors were encountered: