We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description isAuditsDisabled: disabled at org level for type is overruling enabled at site level for type
To Reproduce Steps to reproduce the behavior: Take an organization with config:
{ "config": { "audits": { "auditsDisabled": false, "auditTypeConfigs": { "organic-keywords": { "disabled": true }, "broken-backlinks": { "disabled": true }, "organic-traffic": { "disabled": true } } } } }
Take a site from the organization with auditConfig:
"auditConfig": { "auditsDisabled": false, "auditTypeConfigs": { "organic-keywords": { "disabled": true }, "broken-backlinks": { "disabled": false }, "organic-traffic": { "disabled": true } } }
isAuditsDisabled(site, organization, 'broken-backlinks') returns true.
Expected behavior Given an organization with config:
And a site from the organization with auditConfig:
isAuditsDisabled(site, organization, 'broken-backlinks') should return false.
Additional context https://github.com/adobe/spacecat-shared/blob/main/packages/spacecat-shared-utils/src/helpers.js#L39
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
isAuditsDisabled: disabled at org level for type is overruling enabled at site level for type
To Reproduce
Steps to reproduce the behavior:
Take an organization with config:
Take a site from the organization with auditConfig:
isAuditsDisabled(site, organization, 'broken-backlinks') returns true.
Expected behavior
Given an organization with config:
And a site from the organization with auditConfig:
isAuditsDisabled(site, organization, 'broken-backlinks') should return false.
Additional context
https://github.com/adobe/spacecat-shared/blob/main/packages/spacecat-shared-utils/src/helpers.js#L39
The text was updated successfully, but these errors were encountered: