How to handle audit enabling/disabling for DEFAULT_ORGANIZATION_ID sites

[iuliag]

Overview

How to handle audit enabling/disabling for DEFAULT_ORGANIZATION_ID sites

Details

https://cq-dev.slack.com/archives/C05A45JBP9N/p1712563602198179

https://github.com/adobe/spacecat-api-service/blob/main/src/controllers/trigger/common/trigger.js#L56

spacecat-shared/packages/spacecat-shared-utils/src/helpers.js

Line 41 in 528b370

if (organization.getAuditConfig().auditsDisabled()) {

All created sites land in the default organization, if not otherwise set to a proper organization.
=> all audits (yes, there are exceptions that were not migrated to checking isAuditsDisabled common helper) for sites in the "default" organization are disabled, even if they are later set to enabled at site-level.

If we enable default organization for all audits, then we have to disable all audits for all sites created in the default org first, and re-enable manually for selected ones.

If we create a separate org for the site that revealed this issue to overcome the above, then that org is not DEFAULT_ORGANIZATION_ID and might break reporting about how many real validated customer orgs/sites vs DEFAULT_ORGANIZATION_ID.

Proposed Actions

and now?