From 64755f525f9934d562de676552d76521b7d164a0 Mon Sep 17 00:00:00 2001 From: snewcomer Date: Thu, 25 Feb 2021 17:51:52 -0600 Subject: [PATCH 1/2] validated-changeset 0.14.0 Fix async validation order and add array access --- package.json | 2 +- tests/dummy/app/components/changeset-form.js | 2 +- yarn.lock | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 69517da3..c17dd51b 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ "@glimmer/tracking": "^1.0.1", "ember-auto-import": "^1.5.2", "ember-cli-babel": "^7.19.0", - "validated-changeset": "~0.13.1" + "validated-changeset": "~0.14.0" }, "devDependencies": { "@ember/optional-features": "^1.0.0", diff --git a/tests/dummy/app/components/changeset-form.js b/tests/dummy/app/components/changeset-form.js index 9be82106..e6af2613 100644 --- a/tests/dummy/app/components/changeset-form.js +++ b/tests/dummy/app/components/changeset-form.js @@ -9,7 +9,7 @@ let dummyValidations = { return !!value; }, email(value) { - return value && value.includes('@'); + return new Promise((resolve) => setTimeout(resolve, 400, value && value.includes('@'))); }, }, }; diff --git a/yarn.lock b/yarn.lock index 9a5360a9..9a13bee1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -13497,10 +13497,10 @@ validate-npm-package-name@~2.2.2: dependencies: builtins "0.0.7" -validated-changeset@~0.13.1: - version "0.13.1" - resolved "https://registry.yarnpkg.com/validated-changeset/-/validated-changeset-0.13.1.tgz#cf36dbcfcd18cc0cf92bdfc352e0fed26892a973" - integrity sha512-rKc3wPaS6+XPefiGjCqlOrRCtUDw+6CQnUv8AIyzbYSprzWwFAPTeYtWmYzTDBP9G6AENZ34QXszZlMz9INPGw== +validated-changeset@~0.14.0: + version "0.14.0" + resolved "https://registry.yarnpkg.com/validated-changeset/-/validated-changeset-0.14.0.tgz#fb8636dd7fdb7affd803dab34c59a06c898a32fe" + integrity sha512-QJJPr0WSgxbQp5bfued38JbltrSv64JhGLmvUcO/SKcO34kMyEkW1Do3gWnas3Oh3Xlgbef+wu2HHjOCnNAdaQ== vary@~1.1.2: version "1.1.2" From 63b93c21728c2c8a6ebcfcc001e9345b654b6744 Mon Sep 17 00:00:00 2001 From: snewcomer Date: Thu, 25 Feb 2021 18:22:50 -0600 Subject: [PATCH 2/2] runloop aware --- tests/dummy/app/components/changeset-form.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/dummy/app/components/changeset-form.js b/tests/dummy/app/components/changeset-form.js index e6af2613..853aec65 100644 --- a/tests/dummy/app/components/changeset-form.js +++ b/tests/dummy/app/components/changeset-form.js @@ -1,4 +1,5 @@ import Component from '@ember/component'; +import { later } from '@ember/runloop'; import { action, get } from '@ember/object'; import { tracked } from '@glimmer/tracking'; import { Changeset } from 'ember-changeset'; @@ -9,7 +10,16 @@ let dummyValidations = { return !!value; }, email(value) { - return new Promise((resolve) => setTimeout(resolve, 400, value && value.includes('@'))); + let ok = value && value.includes('@'); + return new Promise((resolve) => + later( + this, + () => { + resolve(ok); + }, + 400 + ) + ); }, }, };