Google Tag Manager dataLayer fix #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the GTM dev guide (https://developers.google.com/tag-manager/devguide) the dataLayer should be set as a global variable and Google will be in charge of retriving such variable with their gtm.js iframe. Fixes adopted-ember-addons#127
…aLayerProp name for google tag manager adapter
|
is this going to be merged eventually? |
|
Any chance to see this incorporated? |
|
Rebased through github interface so needs a test but seems ok now |
icyrizard
reviewed
Mar 20, 2019
| const envParamsString = envParams ? `&${envParams}`: ''; | ||
|
|
||
| assert(`[ember-metrics] You must pass a valid \`id\` to the ${this.toString()} adapter`, id); | ||
|
|
||
| set(this, 'dataLayer', dataLayer); | ||
| window[dataLayerProp] = dataLayerValue; |
There was a problem hiding this comment.
@bugduino I'm new to this but I've just noticed that it seems like you should not use the window if you are not sure you canUseDom. I would suggest to move it down a bit (put it below the canUseDom) to prevent unseen problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the GTM dev guide (https://developers.google.com/tag-manager/devguide) the dataLayer should be set as a global variable and Google will be in charge of retriving such variable with their gtm.js iframe.
Fixes #127