Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATION: hasBlock is deprecated. Use has-block instead. #163

Closed
esbanarango opened this issue Mar 29, 2021 · 5 comments
Closed

DEPRECATION: hasBlock is deprecated. Use has-block instead. #163

esbanarango opened this issue Mar 29, 2021 · 5 comments

Comments

@esbanarango
Copy link

DEPRECATION:

hasBlock is deprecated. Use has-block instead. ('ember-notify/templates/components/ember-notify/message.hbs' @ L1:C6) [deprecation id: has-block-and-has-block-params] See https://emberjs.com/deprecations/v3.x#toc_has-block-and-has-block-params for more details.

@bertdeblock
Copy link

@btecu I see you made a commit for this deprecation on your fork. Were you planning on making a PR for this? Otherwise I can do this as well.

@btecu btecu closed this as completed in cd30c6a Apr 23, 2021
@btecu
Copy link
Member

btecu commented Apr 23, 2021

@bertdeblock I merged that pull request. The change likely requires a major release, since hasBlock was deprecated recently.
However, to release a new version we should fix the tests (#136). Would you be able to help with that?

@bertdeblock
Copy link

Thanks for merging! I don't think it requires a major release though. {{hasBlock}} was an alias for calling {{has-block}} without a block name or for calling it with the block name default.

@btecu btecu mentioned this issue Apr 30, 2021
@btecu
Copy link
Member

btecu commented Apr 30, 2021

@bertdeblock 6.0.1 has been released.

@esbanarango
Copy link
Author

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants