Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backdrop problems back again. #635

Closed
v3ss0n opened this issue Jan 31, 2017 · 4 comments · Fixed by #1201
Closed

Backdrop problems back again. #635

v3ss0n opened this issue Jan 31, 2017 · 4 comments · Fixed by #1201
Labels

Comments

@v3ss0n
Copy link

v3ss0n commented Jan 31, 2017

Since version 1.0.14
Backdrop getting stucked randomly when paper-sidenav is opened repeatedly.

@miguelcobain
Copy link
Collaborator

@v3ss0n can you give an example and instructions to reproduce that problem?
Is it happening on the demo app?

@v3ss0n
Copy link
Author

v3ss0n commented Feb 2, 2017

i will find a way to reproduce it. right now its all fine again.

@joukevandermaas
Copy link
Contributor

joukevandermaas commented Aug 30, 2017

We have this issue too on the beta-2 release. I managed to track it down to this line:

https://github.com/peec/ember-css-transitions/blob/acb057402f6a2f49f2e0e687f3053b16d2ea00c7/addon/mixins/transition-mixin.js#L214

Apparently sometimes the backdrop clone gets replaced by a new clone, a new element with the same ID. At that point this.clone still exists (not null or undefined), but does not actually point to an element that is in the DOM, and so the remove does nothing.

I don't really understand why this happens, and I don't have the time to look into it further at the moment, but this is causing our tests to fail because the scope of integration tests (this.$) keeps getting reset to the backdrop instead of the test container. This happens because sometimes the element is only cleaned up (or not cleaned up in this case) after the test has already finished. Also see this line for why/how the context gets set: https://github.com/emberjs/ember-test-helpers/blob/356dde46f6e71786b67114c2a5f300f9ed5aa25d/lib/ember-test-helpers/test-module-for-component.js#L253).

I know it's not a lot of information, but the TLDR is that this bug still exists 😄

@panthony
Copy link
Contributor

panthony commented Jan 1, 2019

Could it be the same issue as #925?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants