Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select options don't change focus when using arrow keys #688

Closed
Subtletree opened this issue Apr 11, 2017 · 0 comments · Fixed by #1201
Closed

Select options don't change focus when using arrow keys #688

Subtletree opened this issue Apr 11, 2017 · 0 comments · Fixed by #1201

Comments

@Subtletree
Copy link
Collaborator

When moving between select options with up and down keys, ember-power-select uses aria-current=true to show what option is focused by adding styles to .ember-power-select-option[aria-current=true].

Angular material uses the :focus selector to show what option is focused.

Since paper-select doesn't focus the options the focused option is never shown:
screen shot 2017-04-11 at 5 11 31 pm

Angular's version:
screen shot 2017-04-11 at 5 04 03 pm

If I was to put a pull request together for this, would it be preferable to:

  1. Keep to spec and make ember-power-select focus the options.
  2. Add the styles to [aria-current=true]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant