-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accommodate other container base images in testing #1109
Comments
Currently there are Docker images on Ubuntu and Alpine Linux, which are using associated tags( latest, alpine). If that is the same case when producing more variations we need to parameterize ARG IMAGE_VERSION, which is set as default 'latest' for now. |
A big +1 for this !
|
Blocked by https://github.com/AdoptOpenJDK/openjdk-build/issues/1123 and need an issue in https://github.com/AdoptOpenJDK/openjdk-docker to make images available as an artifact of the docker build PRIOR to publishing to their final destination (docker hub, red hat container catalog, etc). |
It feels like we are close to achieving this. With a series of PRs to this repo, and now with AdoptOpenJDK/openjdk-docker#345 about to land. The docker manifest job can then trigger the scanning tool (added by AdoptOpenJDK/openjdk-docker#345) which creates artifacts that can tell a test pipeline what was published and therefore what needs to be tested. |
I am closing this as the changes on the test side are completed. |
AdoptOpenJDK currently creates Docker images on a ubuntu base, which we then pull from hub.docker and test (we currently do not trigger testing from the docker image build, but should, see #773).
When we start producing more variations of Docker images (on Debian or UBI base), we should be testing them, triggered from the Docker image build and possibly using an artifact from the upstream job or some intermediary location (rather than pulling from hub.docker or some other container store).
On build side:
docker save someImage > someImage.tar
and then archive the tar file (artifact)
From test side:
docker load --input someImage.tar
and then build the testAppImage
Currently, we parameterize the FROM statement in the Dockerfiles, not certain we need any additional parameters. Will need to try and see if any other information would be required.
Need to discuss with @dinogun and co-ordinate how we want things to look, and raise an issue/request at https://github.com/AdoptOpenJDK/openjdk-docker for the changes required there.
Also wondering if Docker image builds will every be integrated into the overall build pipelines. For now they are not, and we do not need to wait for that even if it is in plan.
The text was updated successfully, but these errors were encountered: