Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept ADOPTOPENJDK_SHA in test pipeline #2674

Closed
llxia opened this issue Jun 22, 2021 · 2 comments
Closed

Accept ADOPTOPENJDK_SHA in test pipeline #2674

llxia opened this issue Jun 22, 2021 · 2 comments

Comments

@llxia
Copy link
Contributor

llxia commented Jun 22, 2021

In order to support Reproducible Tests , our test pipeline should accept ADOPTOPENJDK_SHA. The user/upstream should be able to set ADOPTOPENJDK_SHA, similar to OPENJ9_SHA. The test pipeline will use ADOPTOPENJDK_SHA if it is provided. If not, ADOPTOPENJDK_BRANCH will be used.

@smlambert
Copy link
Contributor

We need this one before GHC open-source day, but still tagging it in the event it still exists by then.

@llxia
Copy link
Contributor Author

llxia commented Sep 20, 2021

This issue is no longer needed. SHA/tag/branch can be set in ADOPTOPENJDK_BRANCH

@llxia llxia closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants