Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication of test data in MBCS test suite #5161

Open
smlambert opened this issue Mar 20, 2024 · 1 comment
Open

Reduce duplication of test data in MBCS test suite #5161

smlambert opened this issue Mar 20, 2024 · 1 comment
Assignees

Comments

@smlambert
Copy link
Contributor

smlambert commented Mar 20, 2024

Currently the MBCS test suite pulls in test data from unicode.org public data, to be able to compare what the JDK produces, versus what is expected based on the test data.

For expediency, a copy of this test data is in the MBCS_Tests directory. In fact, certain files are duplicate within subdirectories like https://github.com/adoptium/aqa-tests/blob/master/functional/MBCS_Tests/codepoint/data/UnicodeData-15.1.0.txt and https://github.com/adoptium/aqa-tests/blob/master/functional/MBCS_Tests/unicode/data/UnicodeData-15.1.0.txt.

We can improve this in 2 ways:

  • not keeping 2 copies of files, but referring to a single copy that is in a single location (possibly pulled in by the getDependencies job)
  • pulling test data as part of getDependencies job (and possibly noting when new data shows up at the unicode site)

Noting that in a recent update to the MBCS suite #5150, 9 of 13 files were test data, while the 4 src files changed only required 10 lines of code changed. Managing the test data differently would reduce maintenance costs of this suite.

@smlambert
Copy link
Contributor Author

Items to move out of aqa-tests and pulled in as testDependency

  • CLDC_11/ext/icu4j-61_1.jar
  • CLDC_11/ext/icu4j-localespi-61_1.jar
  • codepoint/data/*
  • unicode/data/*

Items to consider **/data/* in other subdirs, though they do not appear to be duplicating content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant