Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider publishing all external test images to Github packages #5763

Open
smlambert opened this issue Nov 19, 2024 · 0 comments
Open

Consider publishing all external test images to Github packages #5763

smlambert opened this issue Nov 19, 2024 · 0 comments

Comments

@smlambert
Copy link
Contributor

smlambert commented Nov 19, 2024

In the past, we included the image generation during the test pipeline because we were supporting an extremely large number of variations / tags.

Since we have trimmed back the number of variants we support, we could consider building and publishing these images to ghcr.io when material inside of the external directory changes, and not during every test pipeline run.

This issue is to investigate the number of images we would want to publish (perhaps all of sanity.external ones that get run during EA pipelines), look at creating a workflow that builds and publishes them, and updates in our test pipeline code to look for an image and pull from the ghcr.io registry if its present, otherwise fall back to building the image from scratch versus always building from scratch (determine how much execution time is saved, the ease or complexity of such a change).

Once we gather some of the above information, we can make a decision on right next steps.

Helpful doc for pushing to ghcr.io from a workflow.

Related: #5657 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant