Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch rhel6||centos6 labels for sw.tool.glibc.2_12 #1171

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Dec 20, 2024

Fixes adoptium/aqa-tests#5754 - this is a more explicit/generic way of determining which machines that tests should be run on.

(Having said that, one of the two machines we have at Adoptium which matches this is offline and the other is going to be decommissioned so this may not serve too much use in the future :-) )

I've added the "new" label to the machines.

@AdamBrousseau would be good to have your approval on this in case your systems will be impacted by this change - I can revert the openj9 label change if required.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa self-assigned this Dec 20, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sxa sxa changed the title switch rhel6||centos6 labels for sw.tool.glibc.2_12 switch rhel6||centos6 labels for sw.tool.glibc.2_12 Dec 20, 2024
Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna
Copy link
Contributor

Waiting for @AdamBrousseau to comment

Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine from a Semeru builds perspective. We don't have any machines with the glibc label nor do we have any cent/rhel6 machines left so this shouldn't affect us.

@karianna karianna merged commit 6a55e2f into adoptium:master Dec 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found
5 participants